Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ac15605 authored by Michal Brzezinski's avatar Michal Brzezinski
Browse files

Fixing success animation during rotation 

Because setting "Finished" state triggers animation, rotating the device also triggers that animation when it's no longer needed (it's meant to be continuation of  "in progress" animation).
Lottie internally uses `remember` instead of `rememberSaveable` so we need to manage state after rotation externally.

Bug: 369945129
Test: finish tutorial, rotate the screen and see animation not played again
Flag: com.android.systemui.shared.new_touchpad_gestures_tutorial
Change-Id: I6996762876164454f331d9751a0b4defe134c727
parent 4a11b491

packages/SystemUI/src/com/android/systemui/inputdevice/tutorial/ui/composable/TutorialAnimation.kt

+5 −1
Original line number Diff line number Diff line
@@ -131,10 +131,14 @@ private fun SuccessAnimation( 
) {

    val composition by

        rememberLottieComposition(LottieCompositionSpec.RawRes(finishedState.successAnimation))

    var animationFinished by rememberSaveable(key = "animationFinished") { mutableStateOf(false) }

    val progress by animateLottieCompositionAsState(composition, iterations = 1)

    if (progress == 1f) {

        animationFinished = true

    }

    LottieAnimation(

        composition = composition,

        progress = { progress },

        progress = { if (animationFinished) 1f else progress },

        dynamicProperties = animationProperties,

        modifier = Modifier.fillMaxSize(),

    )