Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 79ec1736 authored by Christopher Wiley's avatar Christopher Wiley
Browse files

Remove WifiManager#get/setFrequencyBand 

These methods are marked @hide and only partially implemented by
the WifiService.  In general, it seems wrong to strictly prefer
one WiFi band over another for all WiFi operations.  To reduce
implementation complexity, cause setFrequencyBand to become a noop
and getFrequencyBand to reflect the underlying reality, which is
that we will always operate on all supported bands.

Bug: 31148223
Test: Compiles
Change-Id: Iccff517915f7d5ed7e96bf56e4f195b2cda80f0a
parent dfa6e6f1

wifi/java/android/net/wifi/IWifiManager.aidl

+0 −4
Original line number Diff line number Diff line
@@ -97,10 +97,6 @@ interface IWifiManager 


    String getCountryCode();



    void setFrequencyBand(int band, boolean persist);



    int getFrequencyBand();



    boolean isDualBandSupported();



    boolean saveConfiguration();

wifi/java/android/net/wifi/WifiManager.java

+0 −34
Original line number Diff line number Diff line
@@ -1375,40 +1375,6 @@ public class WifiManager { 
       }

    }



    /**

     * Set the operational frequency band.

     * @param band  One of

     *     {@link #WIFI_FREQUENCY_BAND_AUTO},

     *     {@link #WIFI_FREQUENCY_BAND_5GHZ},

     *     {@link #WIFI_FREQUENCY_BAND_2GHZ},

     * @param persist {@code true} if this needs to be remembered

     * @hide

     */

    public void setFrequencyBand(int band, boolean persist) {

        try {

            mService.setFrequencyBand(band, persist);

        } catch (RemoteException e) {

            throw e.rethrowFromSystemServer();

        }

    }



    /**

     * Get the operational frequency band.

     * @return One of

     *     {@link #WIFI_FREQUENCY_BAND_AUTO},

     *     {@link #WIFI_FREQUENCY_BAND_5GHZ},

     *     {@link #WIFI_FREQUENCY_BAND_2GHZ} or

     *     {@code -1} on failure.

     * @hide

     */

    public int getFrequencyBand() {

        try {

            return mService.getFrequencyBand();

        } catch (RemoteException e) {

            throw e.rethrowFromSystemServer();

        }

    }



    /**

     * Check if the chipset supports dual frequency band (2.4 GHz and 5 GHz)

     * @return {@code true} if supported, {@code false} otherwise.