NanoAppMessage: Optimize toString() (7995b5a6) · Commits · e / os / android_frameworks_base

core/java/android/hardware/location/NanoAppMessage.java

+22 −11

Original line number	Diff line number	Diff line
		@@ -229,27 +229,38 @@ public final class NanoAppMessage implements Parcelable {
		public String toString() {
		int length = mMessageBody.length;

		String ret = "NanoAppMessage[type = " + mMessageType + ", length = " + mMessageBody.length
		+ " bytes, " + (mIsBroadcasted ? "broadcast" : "unicast") + ", nanoapp = 0x"
		+ Long.toHexString(mNanoAppId) + ", isReliable = "
		+ (mIsReliable ? "true" : "false") + ", messageSequenceNumber = "
		+ mMessageSequenceNumber + "](";
		StringBuilder out = new StringBuilder();
		out.append( "NanoAppMessage[type = ");
		out.append(mMessageType);
		out.append(", length = ");
		out.append(mMessageBody.length);
		out.append(" bytes, ");
		out.append(mIsBroadcasted ? "broadcast" : "unicast");
		out.append(", nanoapp = 0x");
		out.append(Long.toHexString(mNanoAppId));
		out.append(", isReliable = ");
		out.append(mIsReliable ? "true" : "false");
		out.append(", messageSequenceNumber = ");
		out.append(mMessageSequenceNumber);
		out.append("](");

		if (length > 0) {
		ret += "data = 0x";
		out.append("data = 0x");
		}
		for (int i = 0; i < Math.min(length, DEBUG_LOG_NUM_BYTES); i++) {
		ret += HexEncoding.encodeToString(mMessageBody[i], true /* upperCase */);
		out.append(HexEncoding.encodeToString(mMessageBody[i],
		true /* upperCase */));

		if ((i + 1) % 4 == 0) {
		ret += " ";
		out.append(" ");
		}
		}
		if (length > DEBUG_LOG_NUM_BYTES) {
		ret += "...";
		out.append("...");
		}
		ret += ")";
		out.append(")");

		return ret;
		return out.toString();
		}

		@Override