Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 792bdc51 authored by StevenHarperUK's avatar StevenHarperUK
Browse files

Fixing a bug that when an app is dismissed or loaded that changes 

the current active audio stream, if the volume overlay is visible during the swap,
if you adjust the volume (with hard keys) after the steam has changed while
the panel is still visible, the wrong panel (view) is still visible on-top of the
one that is being adjusted.

A good way to replicate this is to
   Open the Phone APP
   Go to the Keypad Screen
   Adjust the volume (not the icon on the overlay)
   While the volume is visible Hit the HOME hard key
   Before the volume dissapears, adjust the volume with hard keys

You will hear and feel the volume adjusting, but the overlay will not update.

Change-Id: I1c7a23d6e569d8582d3dab20523eef3aa9bdde0c
parent 1e5dab5b

core/java/android/view/VolumePanel.java

+4 −1
Original line number Diff line number Diff line
@@ -400,7 +400,10 @@ public class VolumePanel extends Handler implements OnSeekBarChangeListener, Vie 
        if (LOGD) Log.d(TAG, "onVolumeChanged(streamType: " + streamType + ", flags: " + flags + ")");



        if ((flags & AudioManager.FLAG_SHOW_UI) != 0) {

            if (mActiveStreamType == -1) {

            // If the activePanel is none - or - the one we are updating is not the current active panel

            // then it is likely that the audio stream being updated has been swapped by an app

            // we need to reorder the sliders to bring the new active one to the front

            if (mActiveStreamType == -1 || streamType != mActiveStreamType) {

                reorderSliders(streamType);

            }

            onShowVolumeChanged(streamType, flags);