Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 792bae06 authored by Louis Chang's avatar Louis Chang
Browse files

Remove fix_view_root_call_trace flag 

Bug: 422916574
Test: wm presubmit
Flag: EXEMPT remove flag
Change-Id: I3f7b8165fe9cc26d9f78854e3f1d25282b324c13
parent 2ff65fe5

core/java/android/view/ViewRootImpl.java

+1 −13
Original line number Diff line number Diff line
@@ -134,7 +134,6 @@ import static android.window.DesktopModeFlags.ENABLE_CAPTION_COMPAT_INSET_FORCE_ 
import static com.android.internal.annotations.VisibleForTesting.Visibility.PACKAGE;

import static com.android.text.flags.Flags.disableHandwritingInitiatorForIme;

import static com.android.window.flags.Flags.enableWindowContextResourcesUpdateOnConfigChange;

import static com.android.window.flags.Flags.fixViewRootCallTrace;

import static com.android.window.flags.Flags.predictiveBackSwipeEdgeNoneApi;

import static com.android.window.flags.Flags.reduceChangedExclusionRectsMsgs;

import static com.android.window.flags.Flags.setScPropertiesInClient;
@@ -1563,9 +1562,6 @@ public final class ViewRootImpl implements ViewParent, 
                    mAttachInfo.mPanelParentWindowToken

                            = panelParentView.getApplicationWindowToken();

                }

                if (!fixViewRootCallTrace()) {

                    mAdded = true;

                }

                int res; /* = WindowManagerImpl.ADD_OKAY; */















                // Schedule the first layout -before- adding to the window










@@ -1622,9 +1618,6 @@ public final class ViewRootImpl implements ViewParent,













                    mTmpFrames.compatScale = addResult.frames.compatScale;















                    mInvCompatScale = 1f / addResult.frames.compatScale;















                } catch (RemoteException | RuntimeException e) {













                    if (!fixViewRootCallTrace()) {













                        mAdded = false;













                    }















                    mView = null;















                    mAttachInfo.mRootView = null;















                    mFallbackEventHandler.setView(null);










@@ -1655,9 +1648,6 @@ public final class ViewRootImpl implements ViewParent,













                if (DEBUG_LAYOUT) Log.v(mTag, "Added window " + mWindow);















                if (res < WindowManagerGlobal.ADD_OKAY) {















                    mAttachInfo.mRootView = null;













                    if (!fixViewRootCallTrace()) {













                        mAdded = false;













                    }















                    mFallbackEventHandler.setView(null);















                    unscheduleTraversals();















                    setAccessibilityFocus(null, null);










@@ -1766,9 +1756,7 @@ public final class ViewRootImpl implements ViewParent,













                mFirstInputStage = nativePreImeStage;















                mFirstPostImeInputStage = earlyPostImeStage;















                mPendingInputEventQueueLengthCounterName = "aq:pending:" + counterSuffix;













                if (fixViewRootCallTrace()) {















                mAdded = true;













                }





























                if (!mRemoved || !mAppVisible) {















                    AnimationHandler.requestAnimatorsEnabled(mAppVisible, this);

































core/java/android/window/flags/windowing_sdk.aconfig



+0
−11




























Original line number
Diff line number
Diff line








@@ -107,17 +107,6 @@ flag {













    }















}





























flag {













    namespace: "windowing_sdk"













    name: "fix_view_root_call_trace"













    description: "Do not set mAdded=true unless #setView finished successfully"













    bug: "385705687"













    is_fixed_read_only: true













    metadata {













        purpose: PURPOSE_BUGFIX













    }













}





























flag {















    namespace: "windowing_sdk"















    name: "activity_embedding_metrics"