Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78b18bb2 authored by Nader Jawad's avatar Nader Jawad
Browse files

Fix initialization of snapshot SkImage instance 

Fix issue where the initial snapshot used to create a
resultant SkImage instance with an SkImageFilter applied
was not initialized.

Fixes: 201312688
Test: Re-ran CTS tests
Change-Id: I2440a161c70076850479c562c7c9e6dc8d756236
Merged-In: I2440a161c70076850479c562c7c9e6dc8d756236
parent 10f05d8f

libs/hwui/pipeline/skia/RenderNodeDrawable.cpp

+1 −2
Original line number Diff line number Diff line
@@ -243,13 +243,12 @@ void RenderNodeDrawable::drawContent(SkCanvas* canvas) const { 
            // the corresponding SkImageFilter each time.

            // See b/193145089 and b/197263715

            if (!Properties::enableRenderEffectCache) {

                snapshotImage = renderNode->getLayerSurface()->makeImageSnapshot();

                if (imageFilter) {

                    auto subset = SkIRect::MakeWH(srcBounds.width(), srcBounds.height());

                    snapshotImage = snapshotImage->makeWithFilter(recordingContext, imageFilter,

                                                                  subset, clipBounds.roundOut(),

                                                                  &srcBounds, &offset);

                } else {

                    snapshotImage = renderNode->getLayerSurface()->makeImageSnapshot();

                }

            } else {

                const auto snapshotResult = renderNode->updateSnapshotIfRequired(