Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78870357 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Fix clang-analyzer-core.uninitialized.Branch warnings 

Bug: 154760495
Test: make with WITH_TIDY=1 and DEFAULT_GLOBAL_TIDY_CHECKS=clang-analyzer-core.uninitialized.Branch
Change-Id: I569749166177c25e63b32fb468dccd13797acc05
parent f5ed9171

tools/bit/adb.cpp

+1 −1
Original line number Diff line number Diff line
@@ -200,7 +200,7 @@ skip_bytes(int fd, ssize_t size, char* scratch, int scratchSize) 


static int

skip_unknown_field(int fd, uint64_t tag, char* scratch, int scratchSize) {

    bool done;

    bool done = false;

    int err;

    uint64_t size;

    switch (tag & 0x7) {

tools/incident_section_gen/main.cpp

+5 −2
Original line number Diff line number Diff line
@@ -368,10 +368,13 @@ static bool generatePrivacyFlags(const Descriptor* descriptor, const Destination 
        // Don't generate a variable twice

        if (!hasDefaultFlags[i]) variableNames[fieldName] = false;

    }

    // hasDefaultFlags[i] has been initialized in the above for-loop,

    // but clang-tidy analyzer still report uninitized values.

    // So we use NOLINT to suppress those false positives.



    bool allDefaults = true;

    for (size_t i=0; i<fieldsInOrder.size(); i++) {

        allDefaults &= hasDefaultFlags[i];

        allDefaults &= hasDefaultFlags[i];  // NOLINT(clang-analyzer-core.uninitialized.Assign)

    }



    parents->erase(messageName); // erase the message type name when exit the message.
@@ -384,7 +387,7 @@ static bool generatePrivacyFlags(const Descriptor* descriptor, const Destination 
    printf("Privacy* %s[] = {\n", messageName.c_str());

    for (size_t i=0; i<fieldsInOrder.size(); i++) {

        const FieldDescriptor* field = fieldsInOrder[i];

        if (hasDefaultFlags[i]) continue;

        if (hasDefaultFlags[i]) continue; // NOLINT(clang-analyzer-core.uninitialized.Branch)

        printf("    &%s,\n", getFieldName(field).c_str());

        policyCount++;

    }