Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 786afcb3 authored by Jorim Jaggi's avatar Jorim Jaggi
Browse files

Trim graphics memory when closing the shade 

Graphics memory usually gets trimmed in applications when the
activity goes into the background. We use quite a lot of graphics
memory when the shade/lockscreen is open, and some of them never gets
freed unless the recents activity is closed, because we don't have
these activity-trimming-heuristics for the shade. This change
proactively trims the graphics memory when the shade gets closed or
when the lockscreen is hidden, to emulate the same heuristics as for
activities.

This change also adds trimMemory on RenderThread to systrace to
verify that no jank is introduced with this change.

This change immediately saves around 10-30 MB on an xxhdpi device
after the shade is closed.

Bug: 17581375
Change-Id: I4fb622efb51815fe08187be97ba15d012d4de5d4
parent b7af00f2

libs/hwui/renderthread/CanvasContext.cpp

+1 −0
Original line number Diff line number Diff line
@@ -330,6 +330,7 @@ void CanvasContext::trimMemory(RenderThread& thread, int level) { 
    // No context means nothing to free

    if (!thread.eglManager().hasEglContext()) return;



    ATRACE_CALL();

    thread.eglManager().requireGlContext();

    if (level >= TRIM_MEMORY_COMPLETE) {

        Caches::getInstance().flush(Caches::kFlushMode_Full);

packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBar.java

+8 −0
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ import android.app.Notification; 
import android.app.PendingIntent;

import android.app.StatusBarManager;

import android.content.BroadcastReceiver;

import android.content.ComponentCallbacks2;

import android.content.Context;

import android.content.Intent;

import android.content.IntentFilter;
@@ -95,6 +96,7 @@ import android.view.ViewPropertyAnimator; 
import android.view.ViewStub;

import android.view.ViewTreeObserver;

import android.view.WindowManager;

import android.view.WindowManagerGlobal;

import android.view.accessibility.AccessibilityEvent;

import android.view.accessibility.AccessibilityManager;

import android.view.animation.AccelerateDecelerateInterpolator;
@@ -2413,6 +2415,12 @@ public class PhoneStatusBar extends BaseStatusBar implements DemoMode, 
        setInteracting(StatusBarManager.WINDOW_STATUS_BAR, false);

        showBouncer();

        disable(mDisabledUnmodified, true /* animate */);



        // Trimming will happen later if Keyguard is showing - doing it here might cause a jank in

        // the bouncer appear animation.

        if (!mStatusBarKeyguardViewManager.isShowing()) {

            WindowManagerGlobal.getInstance().trimMemory(ComponentCallbacks2.TRIM_MEMORY_UI_HIDDEN);

        }

    }



    public boolean interceptTouchEvent(MotionEvent event) {

packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarKeyguardViewManager.java

+4 −0
Original line number Diff line number Diff line
@@ -16,6 +16,7 @@ 


package com.android.systemui.statusbar.phone;



import android.content.ComponentCallbacks2;

import android.content.Context;

import android.os.Bundle;

import android.os.RemoteException;
@@ -24,6 +25,7 @@ import android.util.Slog; 
import android.view.KeyEvent;

import android.view.View;

import android.view.ViewGroup;

import android.view.WindowManagerGlobal;



import com.android.internal.policy.IKeyguardShowCallback;

import com.android.internal.widget.LockPatternUtils;
@@ -268,6 +270,8 @@ public class StatusBarKeyguardViewManager { 
                    public void run() {

                        mStatusBarWindowManager.setKeyguardFadingAway(false);

                        mPhoneStatusBar.finishKeyguardFadingAway();

                        WindowManagerGlobal.getInstance().trimMemory(

                                ComponentCallbacks2.TRIM_MEMORY_UI_HIDDEN);

                    }

                });

            } else {