Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 782e063d authored by Sean McQuillan's avatar Sean McQuillan
Browse files

Mark nullability for TextView.setText(char[]) 

Add @NonNull to TextView.setText(@NonNull char[], ...)

This has always thrown a NPE since API 1.

Bug: b/227218386
Test: atest android.widget.TextViewTest
Relnote: "TextView.setText(@NonNull char[], ...) added nullability
annotation."

Change-Id: I212bb5b73d00185f83adb5e74d4acd07a1410ca8
parent 166c7217

core/api/current.txt

+1 −1
Original line number Diff line number Diff line
@@ -57701,7 +57701,7 @@ package android.widget { 
    method public final void setSpannableFactory(android.text.Spannable.Factory);

    method public final void setText(CharSequence);

    method public void setText(CharSequence, android.widget.TextView.BufferType);

    method public final void setText(char[], int, int);

    method public final void setText(@NonNull char[], int, int);

    method public final void setText(@StringRes int);

    method public final void setText(@StringRes int, android.widget.TextView.BufferType);

    method public void setTextAppearance(@StyleRes int);

core/java/android/widget/TextView.java

+1 −1
Original line number Diff line number Diff line
@@ -6678,7 +6678,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener 
     * @param start start index in the char array

     * @param len length of char count after {@code start}

     */

    public final void setText(/* @NonNull */ char[] text, int start, int len) {

    public final void setText(@NonNull char[] text, int start, int len) {

        int oldlen = 0;















        if (start < 0 || len < 0 || start + len > text.length) {