Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78132186 authored by Evan Rosky's avatar Evan Rosky Committed by Ats Jenk
Browse files

Support transient-launch recents with freeform 

There were some narrow checks which would reject transient
launch of recents when there are freeform windows and would
also cause some premature visibility changes.

This resolves that by:
- allowing recents shortcut even if the recents is already visible
  as long as it isn't already on top.
- Allowing transient-launch to transient-hide freeform tasks.

Bug: 302023399
Test: open app in desktop, swipe to overview.
Change-Id: If2e1ef3327bef99e65f713c975eb055e8c832984
parent 61ac7704

services/core/java/com/android/server/wm/ActivityStartController.java

+2 −1
Original line number Diff line number Diff line
@@ -577,7 +577,8 @@ public class ActivityStartController { 
                .getRootTask(WINDOWING_MODE_UNDEFINED, activityType);

        if (rootTask == null) return false;

        final ActivityRecord r = rootTask.topRunningActivity();

        if (r == null || r.isVisibleRequested() || !r.attachedToProcess()

        if (r == null || (r.isVisibleRequested() && rootTask.isTopRootTaskInDisplayArea())

                || !r.attachedToProcess()

                || !r.mActivityComponent.equals(intent.getComponent())

                || !mService.isCallerRecents(r.getUid())

                // Recents keeps invisible while device is locked.

services/core/java/com/android/server/wm/Transition.java

+1 −2
Original line number Diff line number Diff line
@@ -372,8 +372,7 @@ class Transition implements BLASTSyncEngine.TransactionReadyListener { 
            parent.forAllTasks(t -> {

                // Skip transient-launch task

                if (t == transientRootTask) return false;

                if (t.isVisibleRequested() && !t.isAlwaysOnTop()

                        && !t.getWindowConfiguration().tasksAreFloating()) {

                if (t.isVisibleRequested() && !t.isAlwaysOnTop()) {

                    if (t.isRootTask()) {

                        mTransientHideTasks.add(t);

                    }