Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 77dc179b authored by Grace Kloba's avatar Grace Kloba
Browse files

As embedded and full screen shares the same view, 

we have to replace the AbsoluteLayout with
ViewGroup.Layout before setting it to the dialog
as dialog's FrameLayout doesn't accept AbsoluteLayout.

This should fix the crash when changing orientation.
parent 7cabb03d

core/java/android/webkit/WebView.java

+7 −0
Original line number Diff line number Diff line
@@ -5796,6 +5796,13 @@ public class WebView extends AbsoluteLayout 
                        }

                        mFullScreenHolder = new PluginFullScreenHolder(

                                WebView.this, data.mNpp);

                        // as we are sharing the View between full screen and

                        // embedded mode, we have to remove the

                        // AbsoluteLayout.LayoutParams set by embedded mode to

                        // ViewGroup.LayoutParams before adding it to the dialog

                        data.mView.setLayoutParams(new ViewGroup.LayoutParams(

                                ViewGroup.LayoutParams.FILL_PARENT,

                                ViewGroup.LayoutParams.FILL_PARENT));

                        mFullScreenHolder.setContentView(data.mView);

                        mFullScreenHolder.setCancelable(false);

                        mFullScreenHolder.setCanceledOnTouchOutside(false);