Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 777a3b2b authored by Jiakai Zhang's avatar Jiakai Zhang
Browse files

Remove `DexOptHelper.reportBootDexopt`. 

We don't think this code is reporting the data to anywhere now.

Bug: 258223472
Bug: 6527146
Test: Presubmit
Flag: EXEMPT cleanup
Change-Id: I7f0fd165cb60f30731e87c66e2ccf7ec94a82169
parent 690974dc

services/core/java/com/android/server/pm/DexOptHelper.java

+0 −48
Original line number Diff line number Diff line
@@ -49,7 +49,6 @@ import android.util.Log; 
import android.util.Slog;

import android.util.jar.StrictJarFile;



import com.android.internal.logging.MetricsLogger;

import com.android.internal.util.FrameworkStatsLog;

import com.android.internal.util.IndentingPrintWriter;

import com.android.server.LocalManagerRegistry;
@@ -93,10 +92,6 @@ public final class DexOptHelper { 
    private final PackageManagerService mPm;

    private final InstallScenarioHelper mInstallScenarioHelper;



    // Start time for the boot dexopt in performPackageDexOptUpgradeIfNeeded when ART Service is

    // used, to make it available to the onDexoptDone callback.

    private volatile long mBootDexoptStartTime;



    static {

        // Recycle the thread if it's not used for `keepAliveTime`.

        sDexoptExecutor.allowsCoreThreadTimeOut();
@@ -128,27 +123,10 @@ public final class DexOptHelper { 


        Log.i(TAG, "Starting boot dexopt for reason " + reason);



        final long startTime = System.nanoTime();



        mBootDexoptStartTime = startTime;

        getArtManagerLocal()

                .onBoot(reason, null /* progressCallbackExecutor */, null /* progressCallback */);

    }



    private void reportBootDexopt(long startTime, int numDexopted, int numSkipped, int numFailed) {

        final int elapsedTimeSeconds =

                (int) TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() - startTime);



        final Computer newSnapshot = mPm.snapshotComputer();



        MetricsLogger.histogram(mPm.mContext, "opt_dialog_num_dexopted", numDexopted);

        MetricsLogger.histogram(mPm.mContext, "opt_dialog_num_skipped", numSkipped);

        MetricsLogger.histogram(mPm.mContext, "opt_dialog_num_failed", numFailed);

        MetricsLogger.histogram(mPm.mContext, "opt_dialog_num_total",

                numDexopted + numSkipped + numFailed);

        MetricsLogger.histogram(mPm.mContext, "opt_dialog_time_s", elapsedTimeSeconds);

    }



     /**

     * Requests that files preopted on a secondary system partition be copied to the data partition

     * if possible.  Note that the actual copying of the files is accomplished by init for security
@@ -258,32 +236,6 @@ public final class DexOptHelper { 
         */

        @Override

        public void onDexoptDone(@NonNull DexoptResult result) {

            switch (result.getReason()) {

                case ReasonMapping.REASON_FIRST_BOOT:

                case ReasonMapping.REASON_BOOT_AFTER_OTA:

                case ReasonMapping.REASON_BOOT_AFTER_MAINLINE_UPDATE:

                    int numDexopted = 0;

                    int numSkipped = 0;

                    int numFailed = 0;

                    for (DexoptResult.PackageDexoptResult pkgRes :

                            result.getPackageDexoptResults()) {

                        switch (pkgRes.getStatus()) {

                            case DexoptResult.DEXOPT_PERFORMED:

                                numDexopted += 1;

                                break;

                            case DexoptResult.DEXOPT_SKIPPED:

                                numSkipped += 1;

                                break;

                            case DexoptResult.DEXOPT_FAILED:

                                numFailed += 1;

                                break;

                        }

                    }



                    reportBootDexopt(mBootDexoptStartTime, numDexopted, numSkipped, numFailed);

                    break;

            }



            for (DexoptResult.PackageDexoptResult pkgRes : result.getPackageDexoptResults()) {

                CompilerStats.PackageStats stats =

                        mPm.getOrCreateCompilerPackageStats(pkgRes.getPackageName());