Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 77228465 authored by Luca Zuccarini's avatar Luca Zuccarini
Browse files

Remove wtf that is not actually a terrible failure. 

Fix: 396768913
Fix: 396768913
Flag: EXEMPT bugfix
Test: atest ActivityTransitionAnimator --iterations 20
Change-Id: If08925d00837997fa540631ab21e93ca66a840e8
parent 09558664

packages/SystemUI/animation/src/com/android/systemui/animation/ActivityTransitionAnimator.kt

+2 −3
Original line number Diff line number Diff line
@@ -1086,9 +1086,8 @@ constructor( 
                    if (!success) finishedCallback?.onAnimationFinished()

                }

            } else {

                // This should never happen, as either the controller or factory should always be

                // defined. This final call is for safety in case something goes wrong.

                Log.wtf(TAG, "initAndRun with neither a controller nor factory")

                // This happens when onDisposed() has already been called due to the animation being

                // cancelled. Only issue the callback.

                finishedCallback?.onAnimationFinished()

            }

        }

packages/SystemUI/tests/src/com/android/systemui/animation/ActivityTransitionAnimatorTest.kt

+3 −1
Original line number Diff line number Diff line
@@ -350,6 +350,7 @@ class ActivityTransitionAnimatorTest : SysuiTestCase() { 
            val controller = createController()

            val runner = underTest.createEphemeralRunner(controller)

            runner.onAnimationCancelled()

            waitForIdleSync()

            runner.onAnimationStart(

                TRANSIT_NONE,

                emptyArray(),
@@ -357,12 +358,13 @@ class ActivityTransitionAnimatorTest : SysuiTestCase() { 
                emptyArray(),

                iCallback,

            )



            waitForIdleSync()



            verify(controller).onTransitionAnimationCancelled()

            verify(controller, never()).onTransitionAnimationStart(anyBoolean())

            verify(listener).onTransitionAnimationCancelled()

            verify(listener, never()).onTransitionAnimationStart()

            verify(iCallback).onAnimationFinished()

            assertNull(runner.delegate)

        }

    }