Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 77196e36 authored by Achim Thesmann's avatar Achim Thesmann
Browse files

Exempt existing Unsafe Parcel Lint Violations

Exempt existing violations, so the UnsafeParcelApi lint check can be enabled at ERROR level.

Test: m framework-minus-apex-lint
Bug: 436677613
Flag: EXEMPT lint checks
Change-Id: Ib35b26e86b69bdcee5a27c8a3a8842992dfe2b2f
parent 8d61d355
Loading
Loading
Loading
Loading
+814 −0

File changed.

Preview size limit exceeded, changes collapsed.

+3 −0
Original line number Diff line number Diff line
@@ -20,4 +20,7 @@ java_library_static {
    defaults: ["platform_service_defaults"],
    srcs: [":services.autofill-sources"],
    libs: ["services.core"],
    lint: {
        baseline_filename: "lint-baseline.xml",
    },
}
+15 −0
Original line number Diff line number Diff line
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.4.0-alpha08" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha08">

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Bundle.getParcelable()` API usage"
        errorLine1="        final Parcelable result = data.getParcelable(AutofillManager.EXTRA_AUTHENTICATION_RESULT);"
        errorLine2="                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="frameworks/base/services/autofill/java/com/android/server/autofill/Session.java"
            line="3264"
            column="35"/>
    </issue>

</issues>
+132 −0
Original line number Diff line number Diff line
@@ -865,4 +865,136 @@
            column="13"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Bundle.getParcelableArray()` API usage"
        errorLine1="                    Parcelable[] parcelables = value.getParcelableArray("
        errorLine2="                                               ^">
        <location
            file="frameworks/base/services/core/java/com/android/server/accounts/AccountManagerService.java"
            line="4970"
            column="48"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Intent.getParcelableExtra()` API usage"
        errorLine1="            clientIntent = service.getParcelableExtra(Intent.EXTRA_CLIENT_INTENT);"
        errorLine2="                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="out/soong/.intermediates/frameworks/base/services/core/services.core.protologsrc/android_common/gen/services.core.protolog.srcjar!/frameworks/base/services/core/java/com/android/server/am/ActiveServices.java"
            line="4115"
            column="28"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Bundle.getParcelable()` API usage"
        errorLine1="                final T data = result.bundle.getParcelable("
        errorLine2="                               ^">
        <location
            file="frameworks/base/services/core/java/com/android/server/power/stats/BatteryExternalStatsWorker.java"
            line="612"
            column="32"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Bundle.getParcelable()` API usage"
        errorLine1="        return results.getParcelable(EXTRA_VERIFIED_DISPLAY_HASH);"
        errorLine2="               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="out/soong/.intermediates/frameworks/base/services/core/services.core.protologsrc/android_common/gen/services.core.protolog.srcjar!/frameworks/base/services/core/java/com/android/server/wm/DisplayHashController.java"
            line="160"
            column="16"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Bundle.getParcelable()` API usage"
        errorLine1="                mDisplayHashAlgorithms.put(key, results.getParcelable(key));"
        errorLine2="                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="out/soong/.intermediates/frameworks/base/services/core/services.core.protologsrc/android_common/gen/services.core.protolog.srcjar!/frameworks/base/services/core/java/com/android/server/wm/DisplayHashController.java"
            line="256"
            column="49"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Bundle.getParcelable()` API usage"
        errorLine1="                &amp;&amp; n.extras.getParcelable(Notification.EXTRA_PICTURE) != null;"
        errorLine2="                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="frameworks/base/services/core/java/com/android/server/notification/NotificationManagerService.java"
            line="8580"
            column="20"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Bundle.getParcelable()` API usage"
        errorLine1="                &amp;&amp; n.extras.getParcelable(Notification.EXTRA_PICTURE_ICON) != null;"
        errorLine2="                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="frameworks/base/services/core/java/com/android/server/notification/NotificationManagerService.java"
            line="8586"
            column="20"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Parcel.readParcelable()` API usage"
        errorLine1="                result = parcel.readParcelable(ArchivedPackageParcel.class.getClassLoader());"
        errorLine2="                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="frameworks/base/services/core/java/com/android/server/pm/PackageManagerShellCommandDataLoader.java"
            line="274"
            column="26"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Intent.getParcelableExtra()` API usage"
        errorLine1="                    final PendingIntent pi = intent.getParcelableExtra("
        errorLine2="                                             ^">
        <location
            file="out/soong/.intermediates/frameworks/base/services/core/services.core.protologsrc/android_common/gen/services.core.protolog.srcjar!/frameworks/base/services/core/java/com/android/server/wm/Session.java"
            line="427"
            column="46"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Intent.getParcelableExtra()` API usage"
        errorLine1="                    final UserHandle user = intent.getParcelableExtra(Intent.EXTRA_USER);"
        errorLine2="                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="out/soong/.intermediates/frameworks/base/services/core/services.core.protologsrc/android_common/gen/services.core.protolog.srcjar!/frameworks/base/services/core/java/com/android/server/wm/Session.java"
            line="429"
            column="45"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Intent.getParcelableExtra()` API usage"
        errorLine1="                final UserHandle user = intent.getParcelableExtra(Intent.EXTRA_USER);"
        errorLine2="                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="out/soong/.intermediates/frameworks/base/services/core/services.core.protologsrc/android_common/gen/services.core.protolog.srcjar!/frameworks/base/services/core/java/com/android/server/wm/Session.java"
            line="455"
            column="41"/>
    </issue>

    <issue
        id="UnsafeParcelApi"
        message="Unsafe `Bundle.getParcelable()` API usage"
        errorLine1="                final T data = result.bundle.getParcelable(RESULT_RECEIVER_CONTROLLER_KEY);"
        errorLine2="                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="frameworks/base/services/core/java/com/android/server/stats/pull/StatsPullAtomService.java"
            line="1962"
            column="32"/>
    </issue>

</issues>