Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76ff3e01 authored by Louis Pullen-Freilich's avatar Louis Pullen-Freilich
Browse files

Makes View#setTransitionVisibility public and dark-greylists mViewFlags 

Developers should use setTransitionVisibility instead of using
reflection to change the visibility in mViewFlags directly.

Bug: b/123768691
Test: CTS test in topic
Change-Id: I04d76100c53238b92cdc1575bc20af2a6b4410fe
parent 121f9739

api/current.txt

+1 −0
Original line number Diff line number Diff line
@@ -50777,6 +50777,7 @@ package android.view { 
    method public void setTouchDelegate(android.view.TouchDelegate);

    method public void setTransitionAlpha(float);

    method public final void setTransitionName(String);

    method public void setTransitionVisibility(int);

    method public void setTranslationX(float);

    method public void setTranslationY(float);

    method public void setTranslationZ(float);

core/java/android/view/View.java

+13 −7
Original line number Diff line number Diff line
@@ -4147,10 +4147,13 @@ public class View implements Drawable.Callback, KeyEvent.Callback, 














    /**















     * The view flags hold various views states.













     *













     * Use {@link #setTransitionVisibility(int)} to change the visibility of this view without













     * triggering updates.















     * {@hide}















     */















    @ViewDebug.ExportedProperty(formatToHexString = true)













    @UnsupportedAppUsage













    @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)















    int mViewFlags;





























    static class TransformationInfo {










@@ -12801,14 +12804,17 @@ public class View implements Drawable.Callback, KeyEvent.Callback,













    }





























    /**













     * Change the visibility of the View without triggering any other changes. This is













     * important for transitions, where visibility changes should not adjust focus or













     * trigger a new layout. This is only used when the visibility has already been changed













     * and we need a transient value during an animation. When the animation completes,













     * the original visibility value is always restored.













     * Changes the visibility of this View without triggering any other changes. This should only













     * be used by animation frameworks, such as {@link android.transition.Transition}, where













     * visibility changes should not adjust focus or trigger a new layout. Application developers













     * should use {@link #setVisibility} instead to ensure that the hierarchy is correctly updated.













     *













     * <p>Only call this method when a temporary visibility must be applied during an













     * animation and the original visibility value is guaranteed to be reset after the













     * animation completes. Use {@link #setVisibility} in all other cases.</p>















     *















     * @param visibility One of {@link #VISIBLE}, {@link #INVISIBLE}, or {@link #GONE}.













     * @hide













     * @see #setVisibility(int)















     */















    public void setTransitionVisibility(@Visibility int visibility) {















        mViewFlags = (mViewFlags & ~View.VISIBILITY_MASK) | visibility;