Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76f0f19a authored by TYM Tsai's avatar TYM Tsai
Browse files

Show only dialog presentations in the fill dialog 

Remove fallback to dropdown presentation if there is no dialog
presentation. So the fill dialog will only shows suggestions
that is exactly set a dialog presentation.

Bug: 219956625
Test: Manual
Change-Id: I5665e98b17dc2dcff252af3579a69e9a832f8385
parent 1a8f58e7

services/autofill/java/com/android/server/autofill/ui/DialogFillUi.java

+4 −6
Original line number Original line Diff line number Diff line
@@ -275,12 +275,10 @@ final class DialogFillUi { 
            if (index >= 0) {

            if (index >= 0) {

                RemoteViews presentation = dataset.getFieldDialogPresentation(index);

                RemoteViews presentation = dataset.getFieldDialogPresentation(index);

                if (presentation == null) {

                if (presentation == null) {

                    Slog.w(TAG, "fallback to presentation");

                    if (sDebug) {

                    presentation = dataset.getFieldPresentation(index);

                }

                if (presentation == null) {

                        Slog.w(TAG, "not displaying UI on field " + focusedViewId + " because "

                        Slog.w(TAG, "not displaying UI on field " + focusedViewId + " because "

                                + "service didn't provide a presentation for it on " + dataset);

                                + "service didn't provide a presentation for it on " + dataset);

                    }

                    continue;

                    continue;

                }

                }

                final View view;

                final View view;