Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76e70dd1 authored by Eden Mendel's avatar Eden Mendel
Browse files

[Flag Removal] Remove flag com.android.window.flags.scramble_snapshot_file_name 

⚠️ This is an AI generated CL, created by Applied AI team. It has been
reviewed and LGTM’ed by the Applied AI team to make sure this change can
build, pass existing unit tests, pass presubmit checks and is logically
correct. Please review closely to make sure it aligns with your business
logic and product design. You are selected as the reviewer based on flag
ownership history and go/peeps-suggest-reviewers.

- Like what you see? Just LGTM, and the CL will be auto-submitted!
- Don't like what you see? Please help to leave a comment and we will revert the CL.
- Wrong reviewer? Please help to re-assign this CL to more appropriate reviewers.
- Want to report an issue or leave feedback? Please use go/flag-removal-agent-feedback to file a bug against us and we will get back to you.
- Want to stop receiving these CLs from Flag Removal Agent in the future? Please fill out go/flag-removal-agent-opt-out to opt-out.


Bug: 442493270
Test: All TreeHugger presubmit checks passed.
Flag: EXEMPT flag removal
Change-Id: I679aee083eafaeb8c99267c42ba86c4987c48ff2
parent dcbcebda

core/java/android/window/flags/windowing_frontend.aconfig

+0 −10
Original line number Diff line number Diff line
@@ -298,16 +298,6 @@ flag { 
    }

}



flag {

    name: "scramble_snapshot_file_name"

    namespace: "windowing_frontend"

    description: "Scramble the file name of task snapshot."

    bug: "293139053"

    is_fixed_read_only: true

    metadata {

        purpose: PURPOSE_BUGFIX

    }

}



flag {

    name: "enable_handlers_debugging_mode"

services/core/java/com/android/server/wm/BaseAppSnapshotPersister.java

+3 −6
Original line number Diff line number Diff line
@@ -26,7 +26,6 @@ import android.util.SparseBooleanArray; 
import android.window.TaskSnapshot;



import com.android.internal.annotations.VisibleForTesting;

import com.android.window.flags.Flags;



import java.io.File;

import java.util.UUID;
@@ -128,12 +127,10 @@ class BaseAppSnapshotPersister { 


        @NonNull

        File getDirectory(int userId) {

            if (Flags.scrambleSnapshotFileName()) {

            final File directory = getOrInitScrambleDirectory(userId);

            if (directory != null) {

                return directory;

            }

            }

            return getBaseDirectory(userId);

        }

services/tests/wmtests/src/com/android/server/wm/TaskSnapshotPersisterTestBase.java

+1 −7
Original line number Diff line number Diff line
@@ -47,8 +47,6 @@ import android.window.TaskSnapshot; 
import com.android.server.LocalServices;

import com.android.server.pm.UserManagerInternal;

import com.android.server.wm.BaseAppSnapshotPersister.PersistInfoProvider;

import com.android.window.flags.Flags;



import org.junit.After;

import org.junit.AfterClass;

import org.junit.Before;
@@ -149,11 +147,7 @@ class TaskSnapshotPersisterTestBase extends WindowTestsBase { 
    File[] convertFilePath(@NonNull String... fileNames) {

        final File[] files = new File[fileNames.length];

        final String path;

        if (Flags.scrambleSnapshotFileName()) {

        path = mPersister.mPersistInfoProvider.getDirectory(mTestUserId).getPath();

        } else {

            path = FILES_DIR.getPath() + "/snapshots/";

        }

        for (int i = 0; i < fileNames.length; i++) {

            files[i] = new File(path, fileNames[i]);

        }