Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76d91595 authored by Adam Powell's avatar Adam Powell
Browse files

Don't recycle action button views 

Recycling action button views interferes with transition
animations. Suppress menu item view recycling for them.

Change-Id: I69d7561e337be7e4a89b7cf30b6c9439f2d49cc2
parent 9210bc85

core/java/com/android/internal/view/menu/ActionMenuPresenter.java

+2 −4
Original line number Diff line number Diff line
@@ -161,10 +161,8 @@ public class ActionMenuPresenter extends BaseMenuPresenter 
    public View getItemView(final MenuItemImpl item, View convertView, ViewGroup parent) {

        View actionView = item.getActionView();

        if (actionView == null || item.hasCollapsibleActionView()) {

            if (!(convertView instanceof ActionMenuItemView)) {

                convertView = null;

            }

            actionView = super.getItemView(item, convertView, parent);

            // Don't recycle existing item views for action buttons; it interferes with transitions.

            actionView = super.getItemView(item, null, parent);

        }

        actionView.setVisibility(item.isActionViewExpanded() ? View.GONE : View.VISIBLE);