Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 76b50d37 authored by Olivier Gaillard's avatar Olivier Gaillard Committed by Android (Google) Code Review
Browse files

Merge "Add tests for AtomMetricStats."

parents d5df08e3 e3e969c8

cmds/statsd/src/guardrail/StatsdStats.h

+1 −0
Original line number Diff line number Diff line
@@ -511,6 +511,7 @@ private: 
    FRIEND_TEST(StatsdStatsTest, TestAnomalyMonitor);

    FRIEND_TEST(StatsdStatsTest, TestSystemServerCrash);

    FRIEND_TEST(StatsdStatsTest, TestPullAtomStats);

    FRIEND_TEST(StatsdStatsTest, TestAtomMetricsStats);

};



}  // namespace statsd

cmds/statsd/tests/guardrail/StatsdStats_test.cpp

+33 −0
Original line number Diff line number Diff line
@@ -278,6 +278,39 @@ TEST(StatsdStatsTest, TestPullAtomStats) { 
    EXPECT_EQ(3335L, report.pulled_atom_stats(0).max_pull_delay_nanos());

}



TEST(StatsdStatsTest, TestAtomMetricsStats) {

    StatsdStats stats;

    time_t now = time(nullptr);

    // old event, we get it from the stats buffer. should be ignored.

    stats.noteBucketDropped(1000L);



    stats.noteBucketBoundaryDelayNs(1000L, -1L);

    stats.noteBucketBoundaryDelayNs(1000L, -10L);

    stats.noteBucketBoundaryDelayNs(1000L, 2L);



    stats.noteBucketBoundaryDelayNs(1001L, 1L);



    vector<uint8_t> output;

    stats.dumpStats(&output, false);

    StatsdStatsReport report;

    bool good = report.ParseFromArray(&output[0], output.size());

    EXPECT_TRUE(good);



    EXPECT_EQ(2, report.atom_metric_stats().size());



    auto atomStats = report.atom_metric_stats(0);

    EXPECT_EQ(1000L, atomStats.metric_id());

    EXPECT_EQ(1L, atomStats.bucket_dropped());

    EXPECT_EQ(-10L, atomStats.min_bucket_boundary_delay_ns());

    EXPECT_EQ(2L, atomStats.max_bucket_boundary_delay_ns());



    auto atomStats2 = report.atom_metric_stats(1);

    EXPECT_EQ(1001L, atomStats2.metric_id());

    EXPECT_EQ(0L, atomStats2.bucket_dropped());

    EXPECT_EQ(0L, atomStats2.min_bucket_boundary_delay_ns());

    EXPECT_EQ(1L, atomStats2.max_bucket_boundary_delay_ns());

}



TEST(StatsdStatsTest, TestAnomalyMonitor) {

    StatsdStats stats;

    stats.noteRegisteredAnomalyAlarmChanged();