Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 761cab9a authored by Arpan Kaphle's avatar Arpan Kaphle Committed by Android (Google) Code Review
Browse files

Merge "Finalizing V2 Bugs - Removing TODOs" into udc-dev

parents 5b1b82c3 becd35d5

services/credentials/java/com/android/server/credentials/ClearRequestSession.java

+0 −2
Original line number Diff line number Diff line
@@ -119,7 +119,6 @@ public final class ClearRequestSession extends RequestSession<ClearCredentialSta 
    private void respondToClientWithResponseAndFinish() {

        Log.i(TAG, "respondToClientWithResponseAndFinish");

        if (isSessionCancelled()) {

            // TODO: Differentiate btw cancelled and false

            mChosenProviderMetric.setChosenProviderStatus(

                    MetricUtilities.METRICS_PROVIDER_STATUS_FINAL_SUCCESS);

            logApiCall(ApiName.CLEAR_CREDENTIAL, /* apiStatus */
@@ -144,7 +143,6 @@ public final class ClearRequestSession extends RequestSession<ClearCredentialSta 
    private void respondToClientWithErrorAndFinish(String errorType, String errorMsg) {

        Log.i(TAG, "respondToClientWithErrorAndFinish");

        if (isSessionCancelled()) {

            // TODO: Differentiate btw cancelled and false

            logApiCall(ApiName.CLEAR_CREDENTIAL, /* apiStatus */

                    ApiStatus.METRICS_API_STATUS_CLIENT_CANCELED);

            finishSession(/*propagateCancellation=*/true);

services/credentials/java/com/android/server/credentials/CreateRequestSession.java

+0 −2
Original line number Diff line number Diff line
@@ -143,7 +143,6 @@ public final class CreateRequestSession extends RequestSession<CreateCredentialR 
            return;

        }

        if (isSessionCancelled()) {

            // TODO: Differentiate btw cancelled and false

            logApiCall(ApiName.CREATE_CREDENTIAL, /* apiStatus */

                    ApiStatus.METRICS_API_STATUS_CLIENT_CANCELED);

            finishSession(/*propagateCancellation=*/true);
@@ -168,7 +167,6 @@ public final class CreateRequestSession extends RequestSession<CreateCredentialR 
            return;

        }

        if (isSessionCancelled()) {

            // TODO: Differentiate btw cancelled and false

            logApiCall(ApiName.CREATE_CREDENTIAL, /* apiStatus */

                    ApiStatus.METRICS_API_STATUS_CLIENT_CANCELED);

            finishSession(/*propagateCancellation=*/true);

services/credentials/java/com/android/server/credentials/GetRequestSession.java

+0 −1
Original line number Diff line number Diff line
@@ -119,7 +119,6 @@ public final class GetRequestSession extends RequestSession<GetCredentialRequest 
            return;

        }

        if (isSessionCancelled()) {

            // TODO: Differentiate btw cancelled and false

            logApiCall(ApiName.GET_CREDENTIAL, /* apiStatus */

                    ApiStatus.METRICS_API_STATUS_CLIENT_CANCELED);

            finishSession(/*propagateCancellation=*/true);