Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75fbb4bd authored by Jeff Sharkey's avatar Jeff Sharkey
Browse files

Include network type that caused broadcast. 

Network type can be obtained through EXTRA_NETWORK_INFO, but offer
it as first-class extra since the returned NetworkInfo is deprecated.

Bug: 6936247
Change-Id: Ief59577afd2bd930f0f4c5650b413feef86bfbc3
parent 187019c5

api/current.txt

+1 −0
Original line number Diff line number Diff line
@@ -12399,6 +12399,7 @@ package android.net { 
    field public static final java.lang.String EXTRA_EXTRA_INFO = "extraInfo";

    field public static final java.lang.String EXTRA_IS_FAILOVER = "isFailover";

    field public static final deprecated java.lang.String EXTRA_NETWORK_INFO = "networkInfo";

    field public static final java.lang.String EXTRA_NETWORK_TYPE = "networkType";

    field public static final java.lang.String EXTRA_NO_CONNECTIVITY = "noConnectivity";

    field public static final java.lang.String EXTRA_OTHER_NETWORK_INFO = "otherNetwork";

    field public static final java.lang.String EXTRA_REASON = "reason";

core/java/android/net/ConnectivityManager.java

+10 −0
Original line number Diff line number Diff line
@@ -89,10 +89,20 @@ public class ConnectivityManager { 
     *             should always obtain network information through

     *             {@link #getActiveNetworkInfo()} or

     *             {@link #getAllNetworkInfo()}.

     * @see #EXTRA_NETWORK_TYPE

     */

    @Deprecated

    public static final String EXTRA_NETWORK_INFO = "networkInfo";



    /**

     * Network type which triggered a {@link #CONNECTIVITY_ACTION} broadcast.

     * Can be used with {@link #getNetworkInfo(int)} to get {@link NetworkInfo}

     * state based on the calling application.

     *

     * @see android.content.Intent#getIntExtra(String, int)

     */

    public static final String EXTRA_NETWORK_TYPE = "networkType";



    /**

     * The lookup key for a boolean that indicates whether a connect event

     * is for a network to which the connectivity manager was failing over

services/java/com/android/server/ConnectivityService.java

+3 −0
Original line number Diff line number Diff line
@@ -1622,6 +1622,7 @@ public class ConnectivityService extends IConnectivityManager.Stub { 


        Intent intent = new Intent(ConnectivityManager.CONNECTIVITY_ACTION);

        intent.putExtra(ConnectivityManager.EXTRA_NETWORK_INFO, info);

        intent.putExtra(ConnectivityManager.EXTRA_NETWORK_TYPE, info.getType());

        if (info.isFailover()) {

            intent.putExtra(ConnectivityManager.EXTRA_IS_FAILOVER, true);

            info.setFailover(false);
@@ -1748,6 +1749,7 @@ public class ConnectivityService extends IConnectivityManager.Stub { 
    private Intent makeGeneralIntent(NetworkInfo info, String bcastType) {

        Intent intent = new Intent(bcastType);

        intent.putExtra(ConnectivityManager.EXTRA_NETWORK_INFO, info);

        intent.putExtra(ConnectivityManager.EXTRA_NETWORK_TYPE, info.getType());

        if (info.isFailover()) {

            intent.putExtra(ConnectivityManager.EXTRA_IS_FAILOVER, true);

            info.setFailover(false);
@@ -1798,6 +1800,7 @@ public class ConnectivityService extends IConnectivityManager.Stub { 


        Intent intent = new Intent(ConnectivityManager.CONNECTIVITY_ACTION);

        intent.putExtra(ConnectivityManager.EXTRA_NETWORK_INFO, info);

        intent.putExtra(ConnectivityManager.EXTRA_NETWORK_TYPE, info.getType());

        if (getActiveNetworkInfo() == null) {

            intent.putExtra(ConnectivityManager.EXTRA_NO_CONNECTIVITY, true);

        }