Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75e7d1d7 authored by Aurimas Liutikas's avatar Aurimas Liutikas
Browse files

Removes an already defined warning in aapt. 

Apps that expect to use the current SDK don't specify anything in their
manifest and the build system rightfully injects the current SDK.

Any apps that specify their own <uses-sdk> or versionCode are telling
the build system that they are purposely using some other minSdkVersion,
etc (support library demos).

Test: None
Change-Id: I0aba3a71e15703c7bcafcf4d35608a1851dd8567
Fixes: 34901699
parent ed717563

tools/aapt/Resource.cpp

+0 −9
Original line number Diff line number Diff line
@@ -721,11 +721,6 @@ bool addTagAttribute(const sp<XMLNode>& node, const char* ns8, 
    XMLNode::attribute_entry* existingEntry = node->editAttribute(ns, attr);

    if (existingEntry != NULL) {

        if (replaceExisting) {

            if (kIsDebug) {

                printf("Info: AndroidManifest.xml already defines %s (in %s);"

                        " overwriting existing value from manifest.\n",

                        String8(attr).string(), String8(ns).string());

            }

            existingEntry->string = String16(value);

            return true;

        }
@@ -737,10 +732,6 @@ bool addTagAttribute(const sp<XMLNode>& node, const char* ns8, 
            return false;

        }



        fprintf(stderr, "Warning: AndroidManifest.xml already defines %s (in %s);"

                        " using existing value in manifest.\n",

                String8(attr).string(), String8(ns).string());



        // don't stop the build.

        return true;

    }