Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7587c51b authored by chenjean's avatar chenjean
Browse files

Fix the TalkBack announces error panel visibility state 

The root cause of this timing issue to be that windowMagnification is being set to inactive before the panel state has been updated

Bug: 385677943
Flag: EXEMPT bugfix
Test: manual
Test: atest WindowMagnificationControllerTest
Change-Id: I3409b5f5f86dc57ffd2ce70473f2ee1491a56d22
parent 90914439

packages/SystemUI/src/com/android/systemui/accessibility/MagnificationImpl.java

+2 −5
Original line number Diff line number Diff line
@@ -609,15 +609,12 @@ public class MagnificationImpl implements Magnification, CommandQueue.Callbacks 
        final WindowMagnificationController windowMagnificationController =

                mWindowMagnificationControllerSupplier.get(displayId);

        if (windowMagnificationController != null) {

            boolean isWindowMagnifierActivated = windowMagnificationController.isActivated();

            if (isWindowMagnifierActivated) {

            windowMagnificationController.updateDragHandleResourcesIfNeeded(shown);

            }



            if (shown) {

                mA11yLogger.logWithPosition(

                        MagnificationSettingsEvent.MAGNIFICATION_SETTINGS_PANEL_OPENED,

                        isWindowMagnifierActivated

                        windowMagnificationController.isActivated()

                                ? ACCESSIBILITY_MAGNIFICATION_MODE_WINDOW

                                : ACCESSIBILITY_MAGNIFICATION_MODE_FULLSCREEN

                );

packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnificationController.java

+2 −2
Original line number Diff line number Diff line
@@ -1519,12 +1519,12 @@ class WindowMagnificationController implements View.OnTouchListener, SurfaceHold 
    }



    void updateDragHandleResourcesIfNeeded(boolean settingsPanelIsShown) {

        mSettingsPanelVisibility = settingsPanelIsShown;



        if (!isActivated()) {

            return;

        }



        mSettingsPanelVisibility = settingsPanelIsShown;



        mDragView.setBackground(mContext.getResources().getDrawable(settingsPanelIsShown

                ? R.drawable.accessibility_window_magnification_drag_handle_background_change_inset

                : R.drawable.accessibility_window_magnification_drag_handle_background_inset));