Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 75214cc5 authored by Winson's avatar Winson Committed by Winson Chiu
Browse files

Remove ParsedIntentInfo CREATOR 

Its existence allows implicit readParcelable calls to invoke a Parcel
operation with mismatched read/write data sizes, allowing someone to
swap out the data on a reparcel.

Internal classes will use writeIntentInfoToParcel, so this is safe to
remove.

Bug: 191055353

Test: atest com.android.server.pm.test.parsing.parcelling

Change-Id: I44faa635faf8a77894a3dda8adf89c10064e53f1
parent dd894ae8

core/java/android/content/pm/parsing/component/ParsedIntentInfo.java

+0 −14
Original line number Diff line number Diff line
@@ -19,7 +19,6 @@ package android.content.pm.parsing.component; 
import android.annotation.Nullable;

import android.content.IntentFilter;

import android.os.Parcel;

import android.os.Parcelable;

import android.util.Pair;



import com.android.internal.util.DataClass;
@@ -168,19 +167,6 @@ public final class ParsedIntentInfo extends IntentFilter { 
                + '}';

    }



    public static final Parcelable.Creator<ParsedIntentInfo> CREATOR =

            new Parcelable.Creator<ParsedIntentInfo>() {

                @Override

                public ParsedIntentInfo createFromParcel(Parcel source) {

                    return new ParsedIntentInfo(source);

                }



                @Override

                public ParsedIntentInfo[] newArray(int size) {

                    return new ParsedIntentInfo[size];

                }

            };



    public boolean isHasDefault() {

        return hasDefault;

    }