Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74e30c37 authored by Priyanka Advani (xWF)'s avatar Priyanka Advani (xWF) Committed by Android (Google) Code Review
Browse files

Revert "Revert^2 "[1/2][PiP2] Move removePip animation to transi..." 

Revert submission 30991838-remove-pip-transition

Reason for revert: Droidmonitor created revert due to b/385752209. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:30991838-remove-pip-transition

Change-Id: Id5159f0adeb736f1d3b16f0af4fa99b500c040d6
parent cd5d23cc

libs/WindowManager/Shell/src/com/android/wm/shell/pip2/phone/PipMotionHelper.java

+1 −1
Original line number Diff line number Diff line
@@ -350,7 +350,7 @@ public class PipMotionHelper implements PipAppOpsListener.Callback, 
        }

        cancelPhysicsAnimation();

        mMenuController.hideMenu(ANIM_TYPE_DISMISS, false /* resize */);

        mPipScheduler.scheduleRemovePip();

        mPipScheduler.removePipAfterAnimation();

    }



    /** Sets the movement bounds to use to constrain PIP position animations. */

libs/WindowManager/Shell/src/com/android/wm/shell/pip2/phone/PipScheduler.java

+21 −13
Original line number Diff line number Diff line
@@ -122,27 +122,35 @@ public class PipScheduler { 
     * Schedules exit PiP via expand transition.

     */

    public void scheduleExitPipViaExpand() {

        mMainExecutor.execute(() -> {

            if (!mPipTransitionState.isInPip()) return;

        WindowContainerTransaction wct = getExitPipViaExpandTransaction();

        if (wct != null) {

            mMainExecutor.execute(() -> {

                mPipTransitionController.startExitTransition(TRANSIT_EXIT_PIP, wct,

                        null /* destinationBounds */);

            }

            });

        }

    }



    // TODO: Optimize this by running the animation as part of the transition

    /** Runs remove PiP animation and schedules remove PiP transition after the animation ends. */

    public void removePipAfterAnimation() {

        SurfaceControl.Transaction tx = mSurfaceControlTransactionFactory.getTransaction();

        PipAlphaAnimator animator = mPipAlphaAnimatorSupplier.get(mContext,

                mPipTransitionState.getPinnedTaskLeash(), tx, PipAlphaAnimator.FADE_OUT);

        animator.setAnimationEndCallback(this::scheduleRemovePipImmediately);

        animator.start();

    }



    /** Schedules remove PiP transition. */

    public void scheduleRemovePip() {

        mMainExecutor.execute(() -> {

            if (!mPipTransitionState.isInPip()) return;

    private void scheduleRemovePipImmediately() {

        WindowContainerTransaction wct = getRemovePipTransaction();

        if (wct != null) {

            mMainExecutor.execute(() -> {

                mPipTransitionController.startExitTransition(TRANSIT_REMOVE_PIP, wct,

                        null /* destinationBounds */);

            }

            });

        }

    }



    /**

     * Animates resizing of the pinned stack given the duration.

libs/WindowManager/Shell/src/com/android/wm/shell/pip2/phone/PipTransition.java

+5 −11
Original line number Diff line number Diff line
@@ -276,8 +276,7 @@ public class PipTransition extends PipTransitionController implements 
        }



        if (isRemovePipTransition(info)) {

            mPipTransitionState.setState(PipTransitionState.EXITING_PIP);

            return startRemoveAnimation(info, startTransaction, finishTransaction, finishCallback);

            return removePipImmediately(info, startTransaction, finishTransaction, finishCallback);

        }

        return false;

    }
@@ -667,18 +666,13 @@ public class PipTransition extends PipTransitionController implements 
        return true;

    }



    private boolean startRemoveAnimation(@NonNull TransitionInfo info,

    private boolean removePipImmediately(@NonNull TransitionInfo info,

            @NonNull SurfaceControl.Transaction startTransaction,

            @NonNull SurfaceControl.Transaction finishTransaction,

            @NonNull Transitions.TransitionFinishCallback finishCallback) {

        TransitionInfo.Change pipChange = getChangeByToken(info,

                mPipTransitionState.getPipTaskToken());

        mFinishCallback = finishCallback;

        PipAlphaAnimator animator = new PipAlphaAnimator(mContext, pipChange.getLeash(),

                startTransaction, PipAlphaAnimator.FADE_OUT);

        finishTransaction.setAlpha(pipChange.getLeash(), 0f);

        animator.setAnimationEndCallback(this::finishTransition);

        animator.start();

        startTransaction.apply();

        finishCallback.onTransitionFinished(null);

        mPipTransitionState.setState(PipTransitionState.EXITED_PIP);

        return true;

    }

libs/WindowManager/Shell/tests/unittest/src/com/android/wm/shell/pip2/phone/PipSchedulerTest.java

+10 −10
Original line number Diff line number Diff line
@@ -120,22 +120,15 @@ public class PipSchedulerTest { 
    @Test

    public void scheduleExitPipViaExpand_nullTaskToken_noop() {

        setNullPipTaskToken();

        when(mMockPipTransitionState.isInPip()).thenReturn(true);



        mPipScheduler.scheduleExitPipViaExpand();



        verify(mMockMainExecutor, times(1)).execute(mRunnableArgumentCaptor.capture());

        assertNotNull(mRunnableArgumentCaptor.getValue());

        mRunnableArgumentCaptor.getValue().run();



        verify(mMockPipTransitionController, never())

                .startExitTransition(eq(TRANSIT_EXIT_PIP), any(), isNull());

        verify(mMockMainExecutor, never()).execute(any());

    }



    @Test

    public void scheduleExitPipViaExpand_exitTransitionCalled() {

        setMockPipTaskToken();

        when(mMockPipTransitionState.isInPip()).thenReturn(true);



        mPipScheduler.scheduleExitPipViaExpand();
@@ -149,13 +142,20 @@ public class PipSchedulerTest { 


    @Test

    public void removePipAfterAnimation() {

        //TODO: Update once this is changed to run animation as part of transition

        setMockPipTaskToken();

        when(mMockPipTransitionState.isInPip()).thenReturn(true);



        mPipScheduler.scheduleRemovePip();

        mPipScheduler.removePipAfterAnimation();

        verify(mMockAlphaAnimator, times(1))

                .setAnimationEndCallback(mRunnableArgumentCaptor.capture());

        assertNotNull(mRunnableArgumentCaptor.getValue());

        verify(mMockAlphaAnimator, times(1)).start();



        mRunnableArgumentCaptor.getValue().run();



        verify(mMockMainExecutor, times(1)).execute(mRunnableArgumentCaptor.capture());

        assertNotNull(mRunnableArgumentCaptor.getValue());



        mRunnableArgumentCaptor.getValue().run();



        verify(mMockPipTransitionController, times(1))

services/core/java/com/android/server/wm/ActivityTaskSupervisor.java

+2 −3
Original line number Diff line number Diff line
@@ -76,7 +76,6 @@ import static com.android.server.wm.ActivityTaskManagerDebugConfig.TAG_WITH_CLAS 
import static com.android.server.wm.ActivityTaskManagerService.ANIMATE;

import static com.android.server.wm.ActivityTaskManagerService.H.FIRST_SUPERVISOR_TASK_MSG;

import static com.android.server.wm.ActivityTaskManagerService.RELAUNCH_REASON_NONE;

import static com.android.server.wm.ActivityTaskManagerService.isPip2ExperimentEnabled;

import static com.android.server.wm.ClientLifecycleManager.shouldDispatchLaunchActivityItemIndependently;

import static com.android.server.wm.LockTaskController.LOCK_TASK_AUTH_ALLOWLISTED;

import static com.android.server.wm.LockTaskController.LOCK_TASK_AUTH_LAUNCHABLE;
@@ -2524,7 +2523,7 @@ public class ActivityTaskSupervisor implements RecentTasks.Callbacks { 
    void scheduleUpdatePictureInPictureModeIfNeeded(Task task, Rect targetRootTaskBounds) {

        task.forAllActivities(r -> {

            if (!r.attachedToProcess()) return;

            if (!isPip2ExperimentEnabled()) mPipModeChangedActivities.add(r);

            mPipModeChangedActivities.add(r);

            // If we are scheduling pip change, then remove this activity from multi-window

            // change list as the processing of pip change will make sure multi-window changed

            // message is processed in the right order relative to pip changed.
@@ -2533,7 +2532,7 @@ public class ActivityTaskSupervisor implements RecentTasks.Callbacks { 


        mPipModeChangedTargetRootTaskBounds = targetRootTaskBounds;



        if (!isPip2ExperimentEnabled() && !mHandler.hasMessages(REPORT_PIP_MODE_CHANGED_MSG)) {

        if (!mHandler.hasMessages(REPORT_PIP_MODE_CHANGED_MSG)) {

            mHandler.sendEmptyMessage(REPORT_PIP_MODE_CHANGED_MSG);

        }

    }