Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74ab528e authored by Ameer Armaly's avatar Ameer Armaly
Browse files

AccessibilityManagerService: remove uninstalled services from enabled list after service update. 

Bug: 326485767
Test: atest AccessibilityEndToEndTest#testUpdateServiceWithoutIntent_disablesService
Change-Id: I2d986dc8f09a3cf2f31713237e69e15dcef84514
parent 4add2548

services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java

+22 −0
Original line number Diff line number Diff line
@@ -2722,10 +2722,13 @@ public class AccessibilityManagerService extends IAccessibilityManager.Stub 
                userState.mComponentNameToServiceMap;

        boolean isUnlockingOrUnlocked = mUmi.isUserUnlockingOrUnlocked(userState.mUserId);



        // Store the list of installed services.

        mTempComponentNameSet.clear();

        for (int i = 0, count = userState.mInstalledServices.size(); i < count; i++) {

            AccessibilityServiceInfo installedService = userState.mInstalledServices.get(i);

            ComponentName componentName = ComponentName.unflattenFromString(

                    installedService.getId());

            mTempComponentNameSet.add(componentName);



            AccessibilityServiceConnection service = componentNameToServiceMap.get(componentName);
@@ -2785,6 +2788,25 @@ public class AccessibilityManagerService extends IAccessibilityManager.Stub 
            audioManager.setAccessibilityServiceUids(mTempIntArray);

        }

        mActivityTaskManagerService.setAccessibilityServiceUids(mTempIntArray);



        // If any services have been removed, remove them from the enabled list and the touch

        // exploration granted list.

        boolean anyServiceRemoved =

                userState.mEnabledServices.removeIf((comp) -> !mTempComponentNameSet.contains(comp))

                        || userState.mTouchExplorationGrantedServices.removeIf(

                                (comp) -> !mTempComponentNameSet.contains(comp));

        if (anyServiceRemoved) {

            // Update the enabled services setting.

            persistComponentNamesToSettingLocked(

                    Settings.Secure.ENABLED_ACCESSIBILITY_SERVICES,

                    userState.mEnabledServices,

                    userState.mUserId);

            // Update the touch exploration granted services setting.

            persistComponentNamesToSettingLocked(

                    Settings.Secure.TOUCH_EXPLORATION_GRANTED_ACCESSIBILITY_SERVICES,

                    userState.mTouchExplorationGrantedServices,

                    userState.mUserId);

        }

        updateAccessibilityEnabledSettingLocked(userState);

    }