Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7493edc0 authored by Daniel Akinola's avatar Daniel Akinola
Browse files

Stop disruptive "Display connected" announcements 

Its against a11y guidelines to manually call "announceForAccessibility",
so removing the announcement from the display connected chip and
replacing it with an appropriate a11y update

Bug: 438605058
Test: SystemStatusAnimationSchedulerImplTest
Test: manually testing
Flag: com.android.window.flags.enable_updated_display_connection_dialog
Change-Id: Ic6b2115526bcf20c5b875ee8768c1821a8a491ae
parent d02ea380

packages/SystemUI/src/com/android/systemui/statusbar/events/SystemEventChipAnimationController.kt

+1 −1
Original line number Diff line number Diff line
@@ -349,7 +349,7 @@ constructor( 
    }



    override fun announceForAccessibility(contentDescriptions: String) {

        currentAnimatedView?.view?.announceForAccessibility(contentDescriptions)

        currentAnimatedView?.view?.stateDescription = contentDescriptions

    }



    private fun updateDimens(contentArea: Rect) {

packages/SystemUI/tests/src/com/android/systemui/statusbar/events/SystemStatusAnimationSchedulerImplTest.kt

+3 −3
Original line number Diff line number Diff line
@@ -416,7 +416,7 @@ class SystemStatusAnimationSchedulerImplTest(flags: FlagsParameterization) : Sys 
        )

        fastForwardAnimationToState(AnimatingOut)



        verify(mockView).announceForAccessibility(eq(accessibilityDesc))

        verify(mockView).setStateDescription(eq(accessibilityDesc))

    }



    @Test
@@ -435,7 +435,7 @@ class SystemStatusAnimationSchedulerImplTest(flags: FlagsParameterization) : Sys 
        )

        fastForwardAnimationToState(AnimatingOut)



        verify(mockView, never()).announceForAccessibility(any())

        verify(mockView, never()).setStateDescription(any())

    }



    @Test
@@ -454,7 +454,7 @@ class SystemStatusAnimationSchedulerImplTest(flags: FlagsParameterization) : Sys 
        )

        fastForwardAnimationToState(AnimatingOut)



        verify(mockView, never()).announceForAccessibility(any())

        verify(mockView, never()).setStateDescription(any())

    }



    @Test