Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7450614a authored by Prashant Malani's avatar Prashant Malani
Browse files

Move wakelock release to handleMessage 



There were certain code paths in handleDockStateChange() that were
exiting without releasing the wakelock. So we move the release to the
calling function to prevent stray held wakelocks.

Bug: 16841895

Change-Id: I8ae4d2ab8f775c42a893d3bcdef34321c5f631a6
Signed-off-by: default avatarPrashant Malani <pmalani@google.com>
parent 6ebeefa0

services/core/java/com/android/server/DockObserver.java

+1 −3
Original line number Diff line number Diff line
@@ -201,9 +201,6 @@ final class DockObserver extends SystemService { 
            // There are many components in the system watching for this so as to

            // adjust audio routing, screen orientation, etc.

            getContext().sendStickyBroadcastAsUser(intent, UserHandle.ALL);



            // Release the wake lock that was acquired when the message was posted.

            mWakeLock.release();

        }

    }
@@ -213,6 +210,7 @@ final class DockObserver extends SystemService { 
            switch (msg.what) {

                case MSG_DOCK_STATE_CHANGED:

                    handleDockStateChange();

                    mWakeLock.release();

                    break;

            }

        }