Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 73bad98e authored by Tej Singh's avatar Tej Singh
Browse files

Decrease default pull timeout to 2 seconds. 

This can result in more pull failures, but can prohibit slow pullers
from slowing down statsd.

Test: atest GtsStatsdHostTestCases
Test: atest statsd_test
Test: atest FrameworkStatsdTest
Bug: 154056912
Change-Id: Ie30bd3584d808bb11aaaf0fe2057c9adfb198644
parent d7b08c76

apex/statsd/framework/java/android/app/StatsManager.java

+1 −1
Original line number Diff line number Diff line
@@ -120,7 +120,7 @@ public final class StatsManager { 
    /**

     * @hide

     **/

    @VisibleForTesting public static final long DEFAULT_TIMEOUT_MILLIS = 10_000L; // 10 seconds.

    @VisibleForTesting public static final long DEFAULT_TIMEOUT_MILLIS = 2_000L; // 2 seconds.



    /**

     * Constructor for StatsManagerClient.

cmds/statsd/tests/external/StatsCallbackPuller_test.cpp

+2 −2
Original line number Diff line number Diff line
@@ -201,9 +201,9 @@ TEST_F(StatsCallbackPullerTest, RegisterAndTimeout) { 
    int64_t actualPullDurationNs = endTimeNs - startTimeNs;



    // Pull should take at least the timeout amount of time, but should stop early because the delay

    // is bigger.

    // is bigger. Make sure that the time is closer to the timeout, than to the intended delay.

    EXPECT_LT(pullTimeoutNs, actualPullDurationNs);

    EXPECT_GT(pullDelayNs, actualPullDurationNs);

    EXPECT_GT(pullDelayNs / 5, actualPullDurationNs);

    ASSERT_EQ(0, dataHolder.size());



    // Let the pull return and make sure that the dataHolder is not modified.