Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7301a23f authored by Vasu Nori's avatar Vasu Nori
Browse files

Let cachefull-warning be under SQLiteDebug.DEBUG_SQL_CACHE flag 

This warning doesn't really matter much. If a developer wants to
debug the cache usage, it can be done by turning on this flag.
adb bugreport also displays cachestats - which can be used as a debugging tool.

Change-Id: Ied173714d535c271133247ee4768f86d3be359cf
parent 1cde3fbf

core/java/android/database/sqlite/SQLiteDatabase.java

+5 −8
Original line number Diff line number Diff line
@@ -2116,12 +2116,10 @@ public class SQLiteDatabase extends SQLiteClosable { 


            int maxCacheSz = (mConnectionNum == 0) ? mMaxSqlCacheSize :

                    mParentConnObj.mMaxSqlCacheSize;

            boolean printWarning =

                    (mConnectionNum == 0)

            if (SQLiteDebug.DEBUG_SQL_CACHE && (mConnectionNum == 0)

                   ? (!mCacheFullWarning && mCompiledQueries.size() == maxCacheSz)

                   : (!mParentConnObj.mCacheFullWarning &&

                                    mParentConnObj.mCompiledQueries.size() == maxCacheSz);

           if (printWarning) {

                   mParentConnObj.mCompiledQueries.size() == maxCacheSz)) {

                /*

                 * cache size of {@link #mMaxSqlCacheSize} is not enough for this app.

                 * log a warning.
@@ -2130,7 +2128,6 @@ public class SQLiteDatabase extends SQLiteClosable { 
                Log.w(TAG, "Reached MAX size for compiled-sql statement cache for database " +

                        getPath() + ". Use setMaxSqlCacheSize() to increase cachesize. ");

                mCacheFullWarning = true;

                // STOPSHIP enclose the following warnings with "if (SQLiteDebug.DEBUG_SQL_CACHE)"

                Log.d(TAG, "Here are the SQL statements in Cache of database: " + mPath);

                for (String s : mCompiledQueries.keySet()) {

                    Log.d(TAG, "Sql stament in Cache: " + s);