Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72f59046 authored by shaoweishen's avatar shaoweishen Committed by Shaowei Shen
Browse files

[Output Switcher] Refresh list when data set changed 

Since devices size might changed in any time, trigger DataSetChanged
when Controller rebuild media devices.

Bug: 211392105
Test: verified on device
Change-Id: I994fbff7188df3f5b398ef40878efb99934e1fbe
parent 0a771d17

packages/SystemUI/src/com/android/systemui/media/dialog/MediaOutputBaseDialog.java

+11 −1
Original line number Original line Diff line number Diff line
@@ -150,6 +150,10 @@ public abstract class MediaOutputBaseDialog extends SystemUIDialog implements 
    }

    }





    void refresh() {

    void refresh() {

        refresh(false);

    }



    void refresh(boolean deviceSetChanged) {

        // Update header icon

        // Update header icon

        final int iconRes = getHeaderIconRes();

        final int iconRes = getHeaderIconRes();

        final IconCompat iconCompat = getHeaderIcon();

        final IconCompat iconCompat = getHeaderIcon();
@@ -175,7 +179,8 @@ public abstract class MediaOutputBaseDialog extends SystemUIDialog implements 
        }

        }

        if (!mAdapter.isDragging() && !mAdapter.isAnimating()) {

        if (!mAdapter.isDragging() && !mAdapter.isAnimating()) {

            int currentActivePosition = mAdapter.getCurrentActivePosition();

            int currentActivePosition = mAdapter.getCurrentActivePosition();

            if (currentActivePosition >= 0 && currentActivePosition < mAdapter.getItemCount()) {

            if (!deviceSetChanged && currentActivePosition >= 0

                    && currentActivePosition < mAdapter.getItemCount()) {

                mAdapter.notifyItemChanged(currentActivePosition);

                mAdapter.notifyItemChanged(currentActivePosition);

            } else {

            } else {

                mAdapter.notifyDataSetChanged();

                mAdapter.notifyDataSetChanged();
@@ -214,6 +219,11 @@ public abstract class MediaOutputBaseDialog extends SystemUIDialog implements 
        mMainThreadHandler.post(() -> refresh());

        mMainThreadHandler.post(() -> refresh());

    }

    }





    @Override

    public void onDeviceListChanged() {

        mMainThreadHandler.post(() -> refresh(true));

    }



    @Override

    @Override

    public void dismissDialog() {

    public void dismissDialog() {

        dismiss();

        dismiss();

packages/SystemUI/src/com/android/systemui/media/dialog/MediaOutputController.java

+7 −2
Original line number Original line Diff line number Diff line
@@ -166,7 +166,7 @@ public class MediaOutputController implements LocalMediaManager.DeviceCallback { 
    @Override

    @Override

    public void onDeviceListUpdate(List<MediaDevice> devices) {

    public void onDeviceListUpdate(List<MediaDevice> devices) {

        buildMediaDevices(devices);

        buildMediaDevices(devices);

        mCallback.onRouteChanged();

        mCallback.onDeviceListChanged();

    }

    }





    @Override

    @Override
@@ -529,10 +529,15 @@ public class MediaOutputController implements LocalMediaManager.DeviceCallback { 
        void onMediaStoppedOrPaused();

        void onMediaStoppedOrPaused();





        /**

        /**

         * Override to handle the device updating.

         * Override to handle the device status or attributes updating.

         */

         */

        void onRouteChanged();

        void onRouteChanged();





        /**

         * Override to handle the devices set updating.

         */

        void onDeviceListChanged();



        /**

        /**

         * Override to dismiss dialog.

         * Override to dismiss dialog.

         */

         */

packages/SystemUI/tests/src/com/android/systemui/media/dialog/MediaOutputControllerTest.java

+1 −1
Original line number Original line Diff line number Diff line
@@ -201,7 +201,7 @@ public class MediaOutputControllerTest extends SysuiTestCase { 




        assertThat(devices.containsAll(mMediaDevices)).isTrue();

        assertThat(devices.containsAll(mMediaDevices)).isTrue();

        assertThat(devices.size()).isEqualTo(mMediaDevices.size());

        assertThat(devices.size()).isEqualTo(mMediaDevices.size());

        verify(mCb).onRouteChanged();

        verify(mCb).onDeviceListChanged();

    }

    }





    @Test

    @Test