Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72a333a1 authored by David Su's avatar David Su
Browse files

Remove WifiManager.notifyUserOfApBandConversion() 

Removed this API since the notification should be
handled elsewhere, not in Wifi service.
Thus, moved to SettingsBackupAgent.

Bug: 144218444
Test: atest FrameworksWifiApiTests
Change-Id: Ifc0eafac2e61a5434daa20a29a5b22fba3fbc561
parent a91e08f6

wifi/java/android/net/wifi/IWifiManager.aidl

+0 −2
Original line number Diff line number Diff line
@@ -161,8 +161,6 @@ interface IWifiManager 


    boolean setWifiApConfiguration(in WifiConfiguration wifiConfig, String packageName);



    void notifyUserOfApBandConversion(String packageName);



    void enableTdls(String remoteIPAddress, boolean enable);



    void enableTdlsWithMacAddress(String remoteMacAddress, boolean enable);

wifi/java/android/net/wifi/WifiManager.java

+0 −21
Original line number Diff line number Diff line
@@ -3206,27 +3206,6 @@ public class WifiManager { 
        }

    }



    /**

     * Method that triggers a notification to the user about a band conversion

     * (e.g. 5 GHz to 2.4 GHz) to their saved AP config.

     *

     * @hide

     */

    // TODO(b/144218444): move the notification to Settings instead of making this @SystemApi

    @RequiresPermission(android.Manifest.permission.NETWORK_SETTINGS)

    public void notifyUserOfApBandConversion() {

        Log.d(TAG, "apBand was converted, notify the user");

        try {

            IWifiManager iWifiManager = getIWifiManager();

            if (iWifiManager == null) {

                throw new RemoteException("Wifi service is not running");

            }

            iWifiManager.notifyUserOfApBandConversion(mContext.getOpPackageName());

        } catch (RemoteException e) {

            throw e.rethrowFromSystemServer();

        }

    }



    /**

     * Enable/Disable TDLS on a specific local route.

     *

wifi/java/com/android/server/wifi/BaseWifiService.java

+0 −2
Original line number Diff line number Diff line
@@ -42,7 +42,6 @@ import android.net.wifi.hotspot2.IProvisioningCallback; 
import android.net.wifi.hotspot2.OsuProvider;

import android.net.wifi.hotspot2.PasspointConfiguration;

import android.os.IBinder;

import android.os.Messenger;

import android.os.RemoteException;

import android.os.ResultReceiver;

import android.os.WorkSource;
@@ -325,7 +324,6 @@ public class BaseWifiService extends IWifiManager.Stub { 
        throw new UnsupportedOperationException();

    }



    @Override

    public void notifyUserOfApBandConversion(String packageName) {

        throw new UnsupportedOperationException();

    }