Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 72745fff authored by Seonggoo Kang's avatar Seonggoo Kang
Browse files

Prevent duplicated registration of OnComputeInternalInsetsListener 

OnComputeInternalInsetsListener is added when initViews is called,
and initViews is called by onCreate and onConfigurationChanged.
But it is removed only by onDestroy.
Therefore listeners are accumulated and it results performance issue.
So before adding, remove mInsetListener that was previously added.

Change-Id: I494d3f1875613d73d3f9b8e2af286b5800f03196
parent 5e1e38cc

core/java/android/inputmethodservice/InputMethodService.java

+1 −0
Original line number Diff line number Diff line
@@ -708,6 +708,7 @@ public class InputMethodService extends AbstractInputMethodService { 
        mRootView.setSystemUiVisibility(

                View.SYSTEM_UI_FLAG_LAYOUT_STABLE | View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION);

        mWindow.setContentView(mRootView);

        mRootView.getViewTreeObserver().removeOnComputeInternalInsetsListener(mInsetsComputer);

        mRootView.getViewTreeObserver().addOnComputeInternalInsetsListener(mInsetsComputer);

        if (Settings.Global.getInt(getContentResolver(),

                Settings.Global.FANCY_IME_ANIMATIONS, 0) != 0) {