Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 726c374f authored by Steven Moreland's avatar Steven Moreland Committed by Automerger Merge Worker
Browse files

Merge "ServiceManager: waitForService uses allowBlocking" am: b801a513 

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1793027

Change-Id: I18fff5e8d3e5c7e308b218ab95450f9a10593d38
parents 2f6ec8e0 b801a513

core/java/android/os/ServiceManager.java

+6 −1
Original line number Diff line number Diff line
@@ -257,7 +257,12 @@ public final class ServiceManager { 
     *

     * @return {@code null} only if there are permission problems or fatal errors.

     */

    public static native IBinder waitForService(@NonNull String name);

    public static IBinder waitForService(@NonNull String name) {

        return Binder.allowBlocking(waitForServiceNative(name));

    }



    private static native IBinder waitForServiceNative(@NonNull String name);





    /**

     * Returns the specified service from the service manager, if declared.

core/jni/android_os_ServiceManager.cpp

+5 −11
Original line number Diff line number Diff line
@@ -29,11 +29,8 @@ namespace android { 


// Native because we have a client-side wait in waitForService() and we do not

// want an unnecessary second copy of it.

static jobject android_os_ServiceManager_waitForService(

        JNIEnv *env,

        jclass /* clazzObj */,

static jobject android_os_ServiceManager_waitForServiceNative(JNIEnv* env, jclass /* clazzObj */,

                                                              jstring serviceNameObj) {



    const jchar* serviceName = env->GetStringCritical(serviceNameObj, nullptr);

    if (!serviceName) {

        jniThrowNullPointerException(env, nullptr);
@@ -56,11 +53,8 @@ static jobject android_os_ServiceManager_waitForService( 


static const JNINativeMethod method_table[] = {

        /* name, signature, funcPtr */

    {

        "waitForService",

        "(Ljava/lang/String;)Landroid/os/IBinder;",

        (void*)android_os_ServiceManager_waitForService

    },

        {"waitForServiceNative", "(Ljava/lang/String;)Landroid/os/IBinder;",

         (void*)android_os_ServiceManager_waitForServiceNative},

};



int register_android_os_ServiceManager(JNIEnv* env) {