Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71be4b5e authored by Evan Millar's avatar Evan Millar
Browse files

Bring ServiceTestCase in line with current Service APIs and remove unnecessary asserts. 

-Updated onStart() call to onStartCommand()
-Removed asserts that disallowed starting an already bound service and vice versa, since
 that is a valid Service usage pattern.

Change-Id: I79804aef5319a590c74fca54fc990954f7c3fdaa
parent 0e42b29e

test-runner/src/android/test/ServiceTestCase.java

+1 −7
Original line number Diff line number Diff line
@@ -147,9 +147,6 @@ public abstract class ServiceTestCase<T extends Service> extends AndroidTestCase 
     * @param intent The Intent as if supplied to {@link android.content.Context#startService}.

     */

    protected void startService(Intent intent) {

        assertFalse(mServiceStarted);

        assertFalse(mServiceBound);

        

        if (!mServiceAttached) {

            setupService();

        }
@@ -159,7 +156,7 @@ public abstract class ServiceTestCase<T extends Service> extends AndroidTestCase 
            mService.onCreate();

            mServiceCreated = true;

        }

        mService.onStart(intent, mServiceId);

        mService.onStartCommand(intent, 0, mServiceId);

        

        mServiceStarted = true;

    }
@@ -183,9 +180,6 @@ public abstract class ServiceTestCase<T extends Service> extends AndroidTestCase 
     * @return Return an IBinder for making further calls into the Service.

     */

    protected IBinder bindService(Intent intent) {

        assertFalse(mServiceStarted);

        assertFalse(mServiceBound);

        

        if (!mServiceAttached) {

            setupService();

        }