Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7188f946 authored by Wink Saville's avatar Wink Saville
Browse files

Cleanup comments, see bug 2401350. 

Change-Id: Ieaeeba44b235038ad9b75a57b37658738532df3f
parent d615c6f3

telephony/java/com/android/internal/telephony/Phone.java

+0 −5
Original line number Diff line number Diff line
@@ -1399,11 +1399,6 @@ public interface Phone { 


    /* CDMA support methods */



    /*

     * TODO(Moto) TODO(Teleca): can getCdmaMin, getEsn, getMeid use more generic calls

     * already defined getXxxx above?

     */



    /**

     * Retrieves the MIN for CDMA phones.

     */

telephony/java/com/android/internal/telephony/RIL.java

+3 −4
Original line number Diff line number Diff line
@@ -2982,10 +2982,9 @@ public final class RIL extends BaseCommands implements CommandsInterface { 
        numServiceCategories = p.readInt();



        if (numServiceCategories == 0) {

            // TODO(Teleca) TODO(Moto): The logic of providing default

            // values should not be done by this transport layer. And

            // needs to be done by the vendor ril or application logic.

            // TODO(Google): Remove ASAP

            // TODO: The logic of providing default values should

            // not be done by this transport layer. And needs to

            // be done by the vendor ril or application logic.

            int numInts;

            numInts = CDMA_BROADCAST_SMS_NO_OF_SERVICE_CATEGORIES * CDMA_BSI_NO_OF_INTS_STRUCT + 1;

            response = new int[numInts];

telephony/java/com/android/internal/telephony/cdma/CDMAPhone.java

+1 −1
Original line number Diff line number Diff line
@@ -681,7 +681,7 @@ public class CDMAPhone extends PhoneBase { 
    public String getVoiceMailNumber() {

        String number = null;

        SharedPreferences sp = PreferenceManager.getDefaultSharedPreferences(getContext());

        // TODO(Moto): The default value of voicemail number should be read from a system property

        // TODO: The default value of voicemail number should be read from a system property

        number = sp.getString(VM_NUMBER_CDMA, "*86");

        return number;

    }

telephony/java/com/android/internal/telephony/cdma/CdmaInformationRecords.java

+1 −1
Original line number Diff line number Diff line
@@ -74,7 +74,7 @@ public final class CdmaInformationRecords { 
                break;



            case RIL_CDMA_T53_RELEASE_INFO_REC:

                // TODO(Moto): WHAT to do, for now fall through and throw exception

                // TODO: WHAT to do, for now fall through and throw exception

            default:

                throw new RuntimeException("RIL_UNSOL_CDMA_INFO_REC: unsupported record. Got "

                                            + CdmaInformationRecords.idToString(id) + " ");

telephony/java/com/android/internal/telephony/cdma/CdmaServiceStateTracker.java

+1 −3
Original line number Diff line number Diff line
@@ -1622,9 +1622,7 @@ final class CdmaServiceStateTracker extends ServiceStateTracker { 
     * Returns IMSI as MCC + MNC + MIN

     */

    String getImsi() {

        // TODO(Moto): When RUIM is enabled, IMSI will come from RUIM

        // not build-time props. Moto will provide implementation

        // for RUIM-ready case later.

        // TODO: When RUIM is enabled, IMSI will come from RUIM not build-time props.

        String operatorNumeric = SystemProperties.get(

                TelephonyProperties.PROPERTY_ICC_OPERATOR_NUMERIC, "");