Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 716dbf63 authored by Gilles Debunne's avatar Gilles Debunne
Browse files

Removed unnecessary memory allocation in TextView. 

No other obvious unneeded memory allocation related to
text editing and selection was found.

Change-Id: I7d8c9210940982120caeb1e7b75d754557ebf6db
parent 26e3e590

core/java/android/widget/TextView.java

+8 −10
Original line number Diff line number Diff line
@@ -6285,15 +6285,15 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener 
        }



        if (isFocused()) {

            // This offsets because getInterestingRect() is in terms of

            // viewport coordinates, but requestRectangleOnScreen()

            // is in terms of content coordinates.

            // This offsets because getInterestingRect() is in terms of viewport coordinates, but

            // requestRectangleOnScreen() is in terms of content coordinates.



            Rect r = new Rect(x, top, x + 1, bottom);

            getInterestingRect(r, line);

            r.offset(mScrollX, mScrollY);

            if (mTempRect == null) mTempRect = new Rect();

            mTempRect.set(x, top, x + 1, bottom);

            getInterestingRect(mTempRect, line);

            mTempRect.offset(mScrollX, mScrollY);



            if (requestRectangleOnScreen(r)) {

            if (requestRectangleOnScreen(mTempRect)) {

                changed = true;

            }

        }
@@ -8829,9 +8829,7 @@ public class TextView extends View implements ViewTreeObserver.OnPreDrawListener 


            final TextView hostView = TextView.this;



            if (mTempRect == null) {

                mTempRect = new Rect();

            }

            if (mTempRect == null) mTempRect = new Rect();

            final Rect clip = mTempRect;

            clip.left = compoundPaddingLeft;

            clip.top = extendedPaddingTop;