Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 714e647a authored by markchien's avatar markchien Committed by Mark Chien
Browse files

Do not stop IpServer when recieve wifi ap disabling state. 

This is used to fix the race when quickly OFF/ON wifi tethering.
When IpServer is started/stopped, there is callback update tethering
interface status. Before this change, IpServer is stopped when wifi
ap is disabling. Then the next startTethering may fail in wifi because
wifi is in disabling state.
Error pattern: WifiService: Tethering is already active.
No unitest for this CL but it fixed the CtsTetheringTest flakty rate
than around 30% to 0 for more than 100 runs.

Bug: 153925821
Test: atest CtsTetheringTest --iteration 100
Change-Id: I8b65f621abe20799a3a0d410ba1f06368746ee49
parent 17917f7b

packages/Tethering/src/com/android/networkstack/tethering/Tethering.java

+3 −1
Original line number Diff line number Diff line
@@ -922,8 +922,10 @@ public class Tethering { 
                    case WifiManager.WIFI_AP_STATE_ENABLED:

                        enableWifiIpServingLocked(ifname, ipmode);

                        break;

                    case WifiManager.WIFI_AP_STATE_DISABLED:

                    case WifiManager.WIFI_AP_STATE_DISABLING:

                        // We can see this state on the way to disabled.

                        break;

                    case WifiManager.WIFI_AP_STATE_DISABLED:

                    case WifiManager.WIFI_AP_STATE_FAILED:

                    default:

                        disableWifiIpServingLocked(ifname, curState);