Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7143e061 authored by Jeremy Meyer's avatar Jeremy Meyer
Browse files

Don't let aapt2 dedupe configs with different sizes

With the previous logic in aapt2's resource deduper a configuration that
specified a screen size could dominate another with a different screen
size. For example, w600dp-h800dp could dominate w800dp-h1000dp because
everything that would match the latter would also match the former.

If the values were the same the more specific one would get removed
because that code assumed anything that would have gotten the more
specific one will just the more general one instead. But this isn't
necessarily true because there could be a third value that neither
dominates nor is dominated by either of them, say w500dp-h1200dp.

This makes it so we don't dedupe if there is both a width and height and
they are different than the parent node.

Fixes: 414775283
Test: ResourceDeduper_test
Flag: EXEMPT bugfix
Change-Id: Ide687ba0c976316ec9ba0c2b5f91068456bdb7b4
parent a2d6105f
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment