Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7134fcc0 authored by Philip P. Moltmann's avatar Philip P. Moltmann
Browse files

RemotePrintDocument might get destroyed in constructor 

... if it cannot connect to remote PrintDocumentAdapter. Then the state
will be set to destroyed and the print activity will be aborted via the
onDied callback.

Bug: 27899066
Change-Id: Ieb287b92ac21fc71a56b491a1035feaff6cd2837
parent 15d4b5aa

packages/PrintSpooler/src/com/android/printspooler/model/RemotePrintDocument.java

+3 −1
Original line number Diff line number Diff line
@@ -178,6 +178,8 @@ public final class RemotePrintDocument { 
        }

        if (mState == STATE_FAILED) {

            Log.w(LOG_TAG, "Failed before start.");

        } else if (mState == STATE_DESTROYED) {

            Log.w(LOG_TAG, "Destroyed before start.");

        } else {

            if (mState != STATE_INITIAL) {

                throw new IllegalStateException("Cannot start in state:" + stateToString(mState));
@@ -267,7 +269,7 @@ public final class RemotePrintDocument { 
        }

        if (mState != STATE_STARTED && mState != STATE_UPDATED

                && mState != STATE_FAILED && mState != STATE_CANCELING

                && mState != STATE_CANCELED) {

                && mState != STATE_CANCELED && mState != STATE_DESTROYED) {

            throw new IllegalStateException("Cannot finish in state:"

                    + stateToString(mState));

        }