Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 70b75b46 authored by chenedward's avatar chenedward
Browse files

Change the more appropriate exception class for sound settings 

IllegalArgumentException is more appropriate than
InvalidParameterException, because this isn't security exception

Bug: 78330382
Test: atest FrameworksCoreTests:SettingsBackupTest
Change-Id: I2219f08cb8bc7604e74074b3f81fd7d887cd2154
parent 82aaf21a

packages/SettingsProvider/src/com/android/providers/settings/SettingsHelper.java

+2 −2
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@ import android.telephony.TelephonyManager; 
import android.text.TextUtils;

import android.util.ArraySet;



import java.security.InvalidParameterException;

import java.lang.IllegalArgumentException;

import java.util.ArrayList;

import java.util.HashMap;

import java.util.Locale;
@@ -245,7 +245,7 @@ public class SettingsHelper { 
            case Settings.System.ALARM_ALERT:

                return RingtoneManager.TYPE_ALARM;

            default:

                throw new InvalidParameterException("Incorrect ringtone name: " + name);

                throw new IllegalArgumentException("Incorrect ringtone name: " + name);

        }

    }