Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 70b276a1 authored by Andreas Huber's avatar Andreas Huber Committed by Android (Google) Code Review
Browse files

Merge "Signal an error if aac decoding fails early."

parents a4587818 19127e71
Loading
Loading
Loading
Loading
+17 −0
Original line number Diff line number Diff line
@@ -234,6 +234,23 @@ status_t AACDecoder::read(
            mConfig->aacPlusUpsamplingFactor, mConfig->desiredChannels);

        CHECK(mNumDecodedBuffers > 0);

        if (decoderErr != MP4AUDEC_SUCCESS) {
            // If decoding fails this early, the fields in mConfig may
            // not be valid and we cannot recover.

            LOGE("Unable to decode aac content, decoder returned error %d",
                 decoderErr);

            buffer->release();
            buffer = NULL;

            mInputBuffer->release();
            mInputBuffer = NULL;

            return ERROR_UNSUPPORTED;
        }

        if (mNumDecodedBuffers == 1) {
            mUpsamplingFactor = mConfig->aacPlusUpsamplingFactor;
            // Check on the sampling rate to see whether it is changed.