Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f826d37 authored by Caitlin Shkuratov's avatar Caitlin Shkuratov Committed by Android (Google) Code Review
Browse files

Merge "[SB][Chips] Remove some outdated TODOs." into main

parents 0ce938b4 e42f8b8a

packages/SystemUI/src/com/android/systemui/statusbar/chips/ui/viewmodel/OngoingActivityChipViewModel.kt

+0 −1
Original line number Diff line number Diff line
@@ -115,7 +115,6 @@ interface OngoingActivityChipViewModel { 
                // The notification pipeline needs everything to run on the main thread, so keep

                // this event on the main thread.

                applicationScope.launch {

                    // TODO(b/364653005): Move accessibility focus to the HUN when chip is tapped.

                    notifChipsInteractor.onPromotedNotificationChipTapped(notificationKey)

                }

            }

packages/SystemUI/src/com/android/systemui/statusbar/chips/ui/viewmodel/OngoingActivityChipsViewModel.kt

+0 −2
Original line number Diff line number Diff line
@@ -132,7 +132,6 @@ constructor( 
                    LogLevel.INFO,

                    {

                        str1 = call.logName

                        // TODO(b/364653005): Log other information for notification chips.

                        str2 = notifs.map { it.logName }.toString()

                    },

                    { "... > Call=$str1 > Notifs=$str2" },
@@ -377,7 +376,6 @@ constructor( 
    val visibleChipsWithBounds: Flow<Map<String, RectF>> =

        if (StatusBarChipToHunAnimation.isEnabled) {

            combine(visibleChipKeys, chipBounds) { keys, chipBounds ->

                    // TODO: Test chip w/o bounds isn't returned

                    // TODO(b/393369891): Should we provide the placeholder bounds as a backup and

                    // make those bounds public so that [NotificationStackScrollLayout] can do a

                    // good default animation for chips even if we couldn't fetch the bounds for