Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6f5cbf72 authored by Mady Mellor's avatar Mady Mellor
Browse files

Set textChanged for new notifications 

Test: atest NotificationManagerServiceTest
Fixes: 205915893
Change-Id: Id6033e64e98886db8c9ed20e1f34d0cd39d2123f
parent 65031c37

services/core/java/com/android/server/notification/NotificationManagerService.java

+3 −1
Original line number Diff line number Diff line
@@ -7065,7 +7065,9 @@ public class NotificationManagerService extends SystemService { 
                    if (index < 0) {

                        mNotificationList.add(r);

                        mUsageStats.registerPostedByApp(r);

                        r.setInterruptive(isVisuallyInterruptive(null, r));

                        final boolean isInterruptive = isVisuallyInterruptive(null, r);

                        r.setInterruptive(isInterruptive);

                        r.setTextChanged(isInterruptive);

                    } else {

                        old = mNotificationList.get(index);  // Potentially *changes* old

                        mNotificationList.set(index, r);

services/tests/uiservicestests/src/com/android/server/notification/NotificationManagerServiceTest.java

+13 −0
Original line number Diff line number Diff line
@@ -3871,6 +3871,19 @@ public class NotificationManagerServiceTest extends UiServiceTestCase { 
                r.getStats().getDismissalSentiment());

    }



    @Test

    public void testTextChangedSet_forNewNotifs() throws Exception {

        NotificationRecord original = generateNotificationRecord(mTestNotificationChannel);

        mService.addEnqueuedNotification(original);



        NotificationManagerService.PostNotificationRunnable runnable =

                mService.new PostNotificationRunnable(original.getKey());

        runnable.run();

        waitForIdle();



        assertTrue(original.isTextChanged());

    }



    @Test

    public void testVisuallyInterruptive_notSeen() throws Exception {

        NotificationRecord original = generateNotificationRecord(mTestNotificationChannel);