Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6edb6db5 authored by Craig Mautner's avatar Craig Mautner
Browse files

Ignore invalid combination of PowerManager flags. 

ACQUIRE_CAUSES_WAKEUP is supposed to be ignored if combined with
PARTIAL_WAKE_LOCK. Instead it was being carried out for any values
of the WakeLock level.

This change reverts behavior to closely match
previous releases of the framework by only honoring
ACQUIRE_CAUSES_WAKEUP for screen wake lock levels. The only
difference being that in previous releases ACQUIRE_ could have been
combined with PROXIMITY_SCREEN_OFF_WAKE_LOCK (it never was) and
now such a combination will ignore the ACQUIRE_ flag.

Bug 7532258 fixed.

Change-Id: I46e848d8fd1b57e54c63141bf3d4f353986b5bdf
parent 7b0c8779

core/java/android/os/PowerManager.java

+2 −0
Original line number Diff line number Diff line
@@ -182,6 +182,8 @@ public final class PowerManager { 
     * </p><p>

     * Since not all devices have proximity sensors, use {@link #isWakeLockLevelSupported}

     * to determine whether this wake lock level is supported.

     * </p><p>

     * Cannot be used with {@link #ACQUIRE_CAUSES_WAKEUP}.

     * </p>

     *

     * {@hide}

services/java/com/android/server/power/PowerManagerService.java

+12 −1
Original line number Diff line number Diff line
@@ -618,8 +618,19 @@ public final class PowerManagerService extends IPowerManager.Stub 
        }

    }



    private static boolean isScreenLock(final WakeLock wakeLock) {

        switch (wakeLock.mFlags & PowerManager.WAKE_LOCK_LEVEL_MASK) {

            case PowerManager.FULL_WAKE_LOCK:

            case PowerManager.SCREEN_BRIGHT_WAKE_LOCK:

            case PowerManager.SCREEN_DIM_WAKE_LOCK:

                return true;

        }

        return false;

    }



    private void applyWakeLockFlagsOnAcquireLocked(WakeLock wakeLock) {

        if ((wakeLock.mFlags & PowerManager.ACQUIRE_CAUSES_WAKEUP) != 0) {

        if ((wakeLock.mFlags & PowerManager.ACQUIRE_CAUSES_WAKEUP) != 0 &&

                isScreenLock(wakeLock)) {

            wakeUpNoUpdateLocked(SystemClock.uptimeMillis());

        }

    }