Commit 6e9768e9 authored May 14, 2020 by Yohei Yukawa

Make sure to call SomeArgs#recycle() in IMMS#handleMessage

This is a small follow up CL to our previous CL [1], which added a new
internal message MSG_INLINE_SUGGESTIONS_REQUEST and its handler that
rely on SomeArgs but forget to call SomeArgs#recycle().

Although not calling SomeArgs#recycle() doesn't immediately cause any
fatal issue, not doing so basically spoils the purpose of SomeArgs.
With this CL, InputMethodManagerService#handleMessage should call
SomeArgs#recycle() when necessary.

Other than that there is no behavior change.

 [1]: Id222500c373898d576661cacb7a1cb51061041d4
      bc67f2e1

Bug: 147037345
Test: atest CtsAutoFillServiceTestCases
Change-Id: I763bb78c7d1ada327abaa110d423309b17d831d8

parent 8c211a71

services/core/java/com/android/server/inputmethod/InputMethodManagerService.java

+3 −1

Original line number	Diff line number	Diff line
		@@ -4262,7 +4262,7 @@ public class InputMethodManagerService extends IInputMethodManager.Stub
		}

		// ---------------------------------------------------------------
		case MSG_INLINE_SUGGESTIONS_REQUEST:
		case MSG_INLINE_SUGGESTIONS_REQUEST: {
		args = (SomeArgs) msg.obj;
		final InlineSuggestionsRequestInfo requestInfo =
		(InlineSuggestionsRequestInfo) args.arg2;
		@@ -4274,8 +4274,10 @@ public class InputMethodManagerService extends IInputMethodManager.Stub
		} catch (RemoteException e) {
		Slog.w(TAG, "RemoteException calling onCreateInlineSuggestionsRequest(): " + e);
		}
		args.recycle();
		return true;
		}
		}
		return false;
		}