Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6e2281d4 authored by Dianne Hackborn's avatar Dianne Hackborn
Browse files

Fix issue #6686339: 2 taps required to launch notification... 

...or settings from lock screen

When a window is drawn, the code to determine whether it should now
be shown was calling WindowState.isReadyForDisplay().  Part of the
condition of this function is that it is not ready if a policy is
forcing the window to be hidden -- which is the case when the lock
screen is shown.  As a result, we wouldn't show the window at that
point, so wouldn't tell the activity manager that the token's windows
are visibible, and wouldn't tell the lock screen to go away.

This adds a new variation WindowState.isReadyForDisplayIgnoringKeyguard(),
which is the same as the original method but ignores the policy visibility
for app windows.  This allows windows to be go through the complete
path of handling when the window is finally drawn and telling the
activity manager about it, even if behind the lock screen.  By making it
a separate function, we don't impact any other code that is calling the
old function and may be relying on its behavior.

Also cleaned up a little of the dumpsys output.  Most important, the
new ANR section is now moved to the top, since we want
"adb shell dumpsys window" to still give a nice summary of what we
normally care about -- the window stack and important global state.

Change-Id: Ica3ea85ce46f3f5f5cd2cc30fbd9de13d3885a57
parent 0abe556d

policy/src/com/android/internal/policy/impl/PhoneWindowManager.java

+6 −5
Original line number Diff line number Diff line
@@ -4405,12 +4405,13 @@ public class PhoneWindowManager implements WindowManagerPolicy { 
        pw.print(prefix); pw.print("mLidKeyboardAccessibility=");

                pw.print(mLidKeyboardAccessibility);

                pw.print(" mLidNavigationAccessibility="); pw.print(mLidNavigationAccessibility);

                pw.print(" mLidControlsSleep="); pw.print(mLidControlsSleep);

                pw.print(" mLongPressOnPowerBehavior="); pw.println(mLongPressOnPowerBehavior);

                pw.print(" mLidControlsSleep="); pw.println(mLidControlsSleep);

        pw.print(prefix); pw.print("mLongPressOnPowerBehavior=");

                pw.print(mLongPressOnPowerBehavior);

                pw.print(" mHasSoftInput="); pw.println(mHasSoftInput);

        pw.print(prefix); pw.print("mScreenOnEarly="); pw.print(mScreenOnEarly);

                pw.print(" mScreenOnFully="); pw.print(mScreenOnFully);

                pw.print(" mOrientationSensorEnabled="); pw.print(mOrientationSensorEnabled);

                pw.print(" mHasSoftInput="); pw.println(mHasSoftInput);

                pw.print(" mOrientationSensorEnabled="); pw.println(mOrientationSensorEnabled);

        pw.print(prefix); pw.print("mUnrestrictedScreen=("); pw.print(mUnrestrictedScreenLeft);

                pw.print(","); pw.print(mUnrestrictedScreenTop);

                pw.print(") "); pw.print(mUnrestrictedScreenWidth);

services/java/com/android/server/wm/WindowManagerService.java

+16 −13
Original line number Diff line number Diff line
@@ -9537,6 +9537,7 @@ public class WindowManagerService extends IWindowManager.Stub 
                }

            }

        }

        if (mOpeningApps.size() > 0 || mClosingApps.size() > 0) {

            pw.println();

            if (mOpeningApps.size() > 0) {

                pw.print("  mOpeningApps="); pw.println(mOpeningApps);
@@ -9545,6 +9546,7 @@ public class WindowManagerService extends IWindowManager.Stub 
                pw.print("  mClosingApps="); pw.println(mClosingApps);

            }

        }

    }



    void dumpSessionsLocked(PrintWriter pw, boolean dumpAll) {

        pw.println("WINDOW MANAGER SESSIONS (dumpsys window sessions)");
@@ -9798,7 +9800,7 @@ public class WindowManagerService extends IWindowManager.Stub 
                        pw.println(mNextAppTransitionCallback);

            }

            pw.print("  mStartingIconInTransition="); pw.print(mStartingIconInTransition);

                    pw.print(", mSkipAppTransitionAnimation="); pw.println(mSkipAppTransitionAnimation);

                    pw.print(" mSkipAppTransitionAnimation="); pw.println(mSkipAppTransitionAnimation);

        }

    }
@@ -9966,30 +9968,31 @@ public class WindowManagerService extends IWindowManager.Stub 
        }



        synchronized(mWindowMap) {

            pw.println();

            if (dumpAll) {

                pw.println("-------------------------------------------------------------------------------");

            }

            dumpPolicyLocked(pw, args, dumpAll);

            dumpLastANRLocked(pw);

            pw.println();

            if (dumpAll) {

                pw.println("-------------------------------------------------------------------------------");

            }

            dumpSessionsLocked(pw, dumpAll);

            dumpPolicyLocked(pw, args, dumpAll);

            pw.println();

            if (dumpAll) {

                pw.println("-------------------------------------------------------------------------------");

            }

            dumpTokensLocked(pw, dumpAll);

            dumpSessionsLocked(pw, dumpAll);

            pw.println();

            if (dumpAll) {

                pw.println("-------------------------------------------------------------------------------");

            }

            dumpWindowsLocked(pw, dumpAll, null);

            dumpTokensLocked(pw, dumpAll);

            pw.println();

            if (dumpAll) {

                pw.println("-------------------------------------------------------------------------------");

            }

            dumpLastANRLocked(pw);

            dumpWindowsLocked(pw, dumpAll, null);

        }

    }

services/java/com/android/server/wm/WindowState.java

+22 −0
Original line number Diff line number Diff line
@@ -718,6 +718,28 @@ final class WindowState implements WindowManagerPolicy.WindowState { 
                        || ((mAppToken != null) && (mAppToken.mAppAnimator.animation != null)));

    }



    /**

     * Like isReadyForDisplay(), but ignores any force hiding of the window due

     * to the keyguard.

     */

    boolean isReadyForDisplayIgnoringKeyguard() {

        if (mRootToken.waitingToShow &&

                mService.mNextAppTransition != WindowManagerPolicy.TRANSIT_UNSET) {

            return false;

        }

        final AppWindowToken atoken = mAppToken;

        if (atoken == null && !mPolicyVisibility) {

            // If this is not an app window, and the policy has asked to force

            // hide, then we really do want to hide.

            return false;

        }

        return mHasSurface && !mDestroying

                && ((!mAttachedHidden && mViewVisibility == View.VISIBLE

                                && !mRootToken.hidden)

                        || mWinAnimator.mAnimation != null

                        || ((atoken != null) && (atoken.mAppAnimator.animation != null)));

    }



    /**

     * Like isOnScreen, but returns false if the surface hasn't yet

     * been drawn.

services/java/com/android/server/wm/WindowStateAnimator.java

+2 −2
Original line number Diff line number Diff line
@@ -1218,10 +1218,10 @@ class WindowStateAnimator { 
            }

            Slog.v(TAG, "performShow on " + this

                    + ": mDrawState=" + mDrawState + " readyForDisplay="

                    + mWin.isReadyForDisplay()

                    + mWin.isReadyForDisplayIgnoringKeyguard()

                    + " starting=" + (mWin.mAttrs.type == TYPE_APPLICATION_STARTING), e);

        }

        if (mDrawState == READY_TO_SHOW && mWin.isReadyForDisplay()) {

        if (mDrawState == READY_TO_SHOW && mWin.isReadyForDisplayIgnoringKeyguard()) {

            if (SHOW_TRANSACTIONS || DEBUG_ORIENTATION)

                WindowManagerService.logSurface(mWin, "SHOW (performShowLocked)", null);

            if (DEBUG_VISIBILITY) Slog.v(TAG, "Showing " + this