Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6dbf837a authored by Dan Cashman's avatar Dan Cashman
Browse files

v3 APK verification: reset por signedData after verification. 

During the proof-of-rotation additional attribute parsing, each
new certificate needs to be verified by the last.  When doing this
verification, the ByteBuffer position is advanced to its limit, but
it needs to be read again to extract the certificate.  Reset the
signedData ByteBuffer to its original position.

Bug: 64686581
Test: Builds, boots, v3 signed app with rotated cert installs.
Change-Id: Ie95e4c7e99e3cfb9a987638a0c641456af2f34d9
parent 5bc5457a

core/java/android/util/apk/ApkSignatureSchemeV3Verifier.java

+1 −0
Original line number Diff line number Diff line
@@ -477,6 +477,7 @@ public class ApkSignatureSchemeV3Verifier { 
                    }

                }



                signedData.rewind();

                byte[] encodedCert = readLengthPrefixedByteArray(signedData);

                int signedSigAlgorithm = signedData.getInt();

                if (lastCert != null && lastSigAlgorithm != signedSigAlgorithm) {