Clean Paint.mBidiFlags as it is no longer used (6d9fe5bd) · Commits · e / os / android_frameworks_base

core/java/android/text/GraphicsOperations.java

+3 −10

Original line number	Diff line number	Diff line
		@@ -38,7 +38,7 @@ extends CharSequence
		* {@hide}
		*/
		void drawTextRun(Canvas c, int start, int end, int contextStart, int contextEnd,
		float x, float y, int flags, Paint p);
		float x, float y, Paint p);

		/**
		* Just like {@link Paint#measureText}.
		@@ -55,19 +55,12 @@ extends CharSequence
		* @hide
		*/
		float getTextRunAdvances(int start, int end, int contextStart, int contextEnd,
		int flags, float[] advances, int advancesIndex, Paint paint);

		/**
		* Just like {@link Paint#getTextRunAdvances}.
		* @hide
		*/
		float getTextRunAdvances(int start, int end, int contextStart, int contextEnd,
		int flags, float[] advances, int advancesIndex, Paint paint, int reserved);
		float[] advances, int advancesIndex, Paint paint);

		/**
		* Just like {@link Paint#getTextRunCursor}.
		* @hide
		*/
		int getTextRunCursor(int contextStart, int contextEnd, int flags, int offset,
		int getTextRunCursor(int contextStart, int contextEnd, int offset,
		int cursorOpt, Paint p);
		}

core/java/android/text/MeasuredText.java

+2 −5

Original line number	Diff line number	Diff line
		@@ -159,18 +159,15 @@ class MeasuredText {
		mPos = p + len;

		if (mEasy) {
		int flags = mDir == Layout.DIR_LEFT_TO_RIGHT
		? Canvas.DIRECTION_LTR : Canvas.DIRECTION_RTL;
		return paint.getTextRunAdvances(mChars, p, len, p, len, flags, mWidths, p);
		return paint.getTextRunAdvances(mChars, p, len, p, len, mWidths, p);
		}

		float totalAdvance = 0;
		int level = mLevels[p];
		for (int q = p, i = p + 1, e = p + len;; ++i) {
		if (i == e \|\| mLevels[i] != level) {
		int flags = (level & 0x1) == 0 ? Canvas.DIRECTION_LTR : Canvas.DIRECTION_RTL;
		totalAdvance +=
		paint.getTextRunAdvances(mChars, q, i - q, q, i - q, flags, mWidths, q);
		paint.getTextRunAdvances(mChars, q, i - q, q, i - q, mWidths, q);
		if (i == e) {
		break;
		}

core/java/android/text/SpannableStringBuilder.java

+21 −42

Original line number	Diff line number	Diff line
		@@ -1130,20 +1130,20 @@ public class SpannableStringBuilder implements CharSequence, GetChars, Spannable
		* {@hide}
		*/
		public void drawTextRun(Canvas c, int start, int end, int contextStart, int contextEnd,
		float x, float y, int flags, Paint p) {
		float x, float y, Paint p) {
		checkRange("drawTextRun", start, end);

		int contextLen = contextEnd - contextStart;
		int len = end - start;
		if (contextEnd <= mGapStart) {
		c.drawTextRun(mText, start, len, contextStart, contextLen, x, y, flags, p);
		c.drawTextRun(mText, start, len, contextStart, contextLen, x, y, p);
		} else if (contextStart >= mGapStart) {
		c.drawTextRun(mText, start + mGapLength, len, contextStart + mGapLength,
		contextLen, x, y, flags, p);
		contextLen, x, y, p);
		} else {
		char[] buf = TextUtils.obtain(contextLen);
		getChars(contextStart, contextEnd, buf, 0);
		c.drawTextRun(buf, start - contextStart, len, 0, contextLen, x, y, flags, p);
		c.drawTextRun(buf, start - contextStart, len, 0, contextLen, x, y, p);
		TextUtils.recycle(buf);
		}
		}
		@@ -1200,7 +1200,7 @@ public class SpannableStringBuilder implements CharSequence, GetChars, Spannable
		* Don't call this yourself -- exists for Paint to use internally.
		* {@hide}
		*/
		public float getTextRunAdvances(int start, int end, int contextStart, int contextEnd, int flags,
		public float getTextRunAdvances(int start, int end, int contextStart, int contextEnd,
		float[] advances, int advancesPos, Paint p) {

		float ret;
		@@ -1210,44 +1210,15 @@ public class SpannableStringBuilder implements CharSequence, GetChars, Spannable

		if (end <= mGapStart) {
		ret = p.getTextRunAdvances(mText, start, len, contextStart, contextLen,
		flags, advances, advancesPos);
		advances, advancesPos);
		} else if (start >= mGapStart) {
		ret = p.getTextRunAdvances(mText, start + mGapLength, len,
		contextStart + mGapLength, contextLen, flags, advances, advancesPos);
		contextStart + mGapLength, contextLen, advances, advancesPos);
		} else {
		char[] buf = TextUtils.obtain(contextLen);
		getChars(contextStart, contextEnd, buf, 0);
		ret = p.getTextRunAdvances(buf, start - contextStart, len,
		0, contextLen, flags, advances, advancesPos);
		TextUtils.recycle(buf);
		}

		return ret;
		}

		/**
		* Don't call this yourself -- exists for Paint to use internally.
		* {@hide}
		*/
		public float getTextRunAdvances(int start, int end, int contextStart, int contextEnd, int flags,
		float[] advances, int advancesPos, Paint p, int reserved) {

		float ret;

		int contextLen = contextEnd - contextStart;
		int len = end - start;

		if (end <= mGapStart) {
		ret = p.getTextRunAdvances(mText, start, len, contextStart, contextLen,
		flags, advances, advancesPos, reserved);
		} else if (start >= mGapStart) {
		ret = p.getTextRunAdvances(mText, start + mGapLength, len,
		contextStart + mGapLength, contextLen, flags, advances, advancesPos, reserved);
		} else {
		char[] buf = TextUtils.obtain(contextLen);
		getChars(contextStart, contextEnd, buf, 0);
		ret = p.getTextRunAdvances(buf, start - contextStart, len,
		0, contextLen, flags, advances, advancesPos, reserved);
		0, contextLen, advances, advancesPos);
		TextUtils.recycle(buf);
		}

		@@ -1270,7 +1241,7 @@ public class SpannableStringBuilder implements CharSequence, GetChars, Spannable
		*
		* @param contextStart the start index of the context
		* @param contextEnd the (non-inclusive) end index of the context
		* @param flags either DIRECTION_RTL or DIRECTION_LTR
		* @param flags reserved
		* @param offset the cursor position to move from
		* @param cursorOpt how to move the cursor, one of CURSOR_AFTER,
		* CURSOR_AT_OR_AFTER, CURSOR_BEFORE,
		@@ -1282,21 +1253,29 @@ public class SpannableStringBuilder implements CharSequence, GetChars, Spannable
		@Deprecated
		public int getTextRunCursor(int contextStart, int contextEnd, int flags, int offset,
		int cursorOpt, Paint p) {
		return getTextRunCursor(contextStart, contextEnd, offset, cursorOpt, p);
		}

		/**
		* @hide
		*/
		public int getTextRunCursor(int contextStart, int contextEnd, int offset,
		int cursorOpt, Paint p) {

		int ret;

		int contextLen = contextEnd - contextStart;
		if (contextEnd <= mGapStart) {
		ret = p.getTextRunCursor(mText, contextStart, contextLen,
		flags, offset, cursorOpt);
		offset, cursorOpt);
		} else if (contextStart >= mGapStart) {
		ret = p.getTextRunCursor(mText, contextStart + mGapLength, contextLen,
		flags, offset + mGapLength, cursorOpt) - mGapLength;
		offset + mGapLength, cursorOpt) - mGapLength;
		} else {
		char[] buf = TextUtils.obtain(contextLen);
		getChars(contextStart, contextEnd, buf, 0);
		ret = p.getTextRunCursor(buf, 0, contextLen,
		flags, offset - contextStart, cursorOpt) + contextStart;
		offset - contextStart, cursorOpt) + contextStart;
		TextUtils.recycle(buf);
		}

core/java/android/text/TextLine.java

+9 −15

Original line number	Diff line number	Diff line
		@@ -664,14 +664,13 @@ class TextLine {
		}
		}

		int flags = runIsRtl ? Paint.DIRECTION_RTL : Paint.DIRECTION_LTR;
		int cursorOpt = after ? Paint.CURSOR_AFTER : Paint.CURSOR_BEFORE;
		if (mCharsValid) {
		return wp.getTextRunCursor(mChars, spanStart, spanLimit - spanStart,
		flags, offset, cursorOpt);
		offset, cursorOpt);
		} else {
		return wp.getTextRunCursor(mText, mStart + spanStart,
		mStart + spanLimit, flags, mStart + offset, cursorOpt) - mStart;
		mStart + spanLimit, mStart + offset, cursorOpt) - mStart;
		}
		}

		@@ -738,15 +737,13 @@ class TextLine {

		int contextLen = contextEnd - contextStart;
		if (needWidth \|\| (c != null && (wp.bgColor != 0 \|\| wp.underlineColor != 0 \|\| runIsRtl))) {
		int flags = runIsRtl ? Paint.DIRECTION_RTL : Paint.DIRECTION_LTR;
		if (mCharsValid) {
		ret = wp.getTextRunAdvances(mChars, start, runLen,
		contextStart, contextLen, flags, null, 0);
		contextStart, contextLen, null, 0);
		} else {
		int delta = mStart;
		ret = wp.getTextRunAdvances(mText, delta + start,
		delta + end, delta + contextStart, delta + contextEnd,
		flags, null, 0);
		ret = wp.getTextRunAdvances(mText, delta + start, delta + end,
		delta + contextStart, delta + contextEnd, null, 0);
		}
		}

		@@ -786,8 +783,7 @@ class TextLine {
		wp.setAntiAlias(previousAntiAlias);
		}

		drawTextRun(c, wp, start, end, contextStart, contextEnd, runIsRtl,
		x, y + wp.baselineShift);
		drawTextRun(c, wp, start, end, contextStart, contextEnd, x, y + wp.baselineShift);
		}

		return runIsRtl ? -ret : ret;
		@@ -970,23 +966,21 @@ class TextLine {
		* @param end the end of the run
		* @param contextStart the start of context for the run
		* @param contextEnd the end of the context for the run
		* @param runIsRtl true if the run is right-to-left
		* @param x the x position of the left edge of the run
		* @param y the baseline of the run
		*/
		private void drawTextRun(Canvas c, TextPaint wp, int start, int end,
		int contextStart, int contextEnd, boolean runIsRtl, float x, int y) {
		int contextStart, int contextEnd, float x, int y) {

		int flags = runIsRtl ? Canvas.DIRECTION_RTL : Canvas.DIRECTION_LTR;
		if (mCharsValid) {
		int count = end - start;
		int contextCount = contextEnd - contextStart;
		c.drawTextRun(mChars, start, count, contextStart, contextCount,
		x, y, flags, wp);
		x, y, wp);
		} else {
		int delta = mStart;
		c.drawTextRun(mText, delta + start, delta + end,
		delta + contextStart, delta + contextEnd, x, y, flags, wp);
		delta + contextStart, delta + contextEnd, x, y, wp);
		}
		}

core/java/android/view/GLES20Canvas.java

+19 −26

Original line number	Diff line number	Diff line
		@@ -1176,14 +1176,14 @@ class GLES20Canvas extends HardwareCanvas {

		int modifiers = setupModifiers(paint);
		try {
		nDrawText(mRenderer, text, index, count, x, y, paint.mBidiFlags, paint.mNativePaint);
		nDrawText(mRenderer, text, index, count, x, y, paint.mNativePaint);
		} finally {
		if (modifiers != MODIFIER_NONE) nResetModifiers(mRenderer, modifiers);
		}
		}

		private static native void nDrawText(int renderer, char[] text, int index, int count,
		float x, float y, int bidiFlags, int paint);
		float x, float y, int paint);

		@Override
		public void drawText(CharSequence text, int start, int end, float x, float y, Paint paint) {
		@@ -1191,16 +1191,14 @@ class GLES20Canvas extends HardwareCanvas {
		try {
		if (text instanceof String \|\| text instanceof SpannedString \|\|
		text instanceof SpannableString) {
		nDrawText(mRenderer, text.toString(), start, end, x, y, paint.mBidiFlags,
		paint.mNativePaint);
		nDrawText(mRenderer, text.toString(), start, end, x, y, paint.mNativePaint);
		} else if (text instanceof GraphicsOperations) {
		((GraphicsOperations) text).drawText(this, start, end, x, y,
		paint);
		} else {
		char[] buf = TemporaryBuffer.obtain(end - start);
		TextUtils.getChars(text, start, end, buf, 0);
		nDrawText(mRenderer, buf, 0, end - start, x, y,
		paint.mBidiFlags, paint.mNativePaint);
		nDrawText(mRenderer, buf, 0, end - start, x, y, paint.mNativePaint);
		TemporaryBuffer.recycle(buf);
		}
		} finally {
		@@ -1216,21 +1214,20 @@ class GLES20Canvas extends HardwareCanvas {

		int modifiers = setupModifiers(paint);
		try {
		nDrawText(mRenderer, text, start, end, x, y, paint.mBidiFlags, paint.mNativePaint);
		nDrawText(mRenderer, text, start, end, x, y, paint.mNativePaint);
		} finally {
		if (modifiers != MODIFIER_NONE) nResetModifiers(mRenderer, modifiers);
		}
		}

		private static native void nDrawText(int renderer, String text, int start, int end,
		float x, float y, int bidiFlags, int paint);
		float x, float y, int paint);

		@Override
		public void drawText(String text, float x, float y, Paint paint) {
		int modifiers = setupModifiers(paint);
		try {
		nDrawText(mRenderer, text, 0, text.length(), x, y, paint.mBidiFlags,
		paint.mNativePaint);
		nDrawText(mRenderer, text, 0, text.length(), x, y, paint.mNativePaint);
		} finally {
		if (modifiers != MODIFIER_NONE) nResetModifiers(mRenderer, modifiers);
		}
		@@ -1246,14 +1243,14 @@ class GLES20Canvas extends HardwareCanvas {
		int modifiers = setupModifiers(paint);
		try {
		nDrawTextOnPath(mRenderer, text, index, count, path.mNativePath, hOffset, vOffset,
		paint.mBidiFlags, paint.mNativePaint);
		paint.mNativePaint);
		} finally {
		if (modifiers != MODIFIER_NONE) nResetModifiers(mRenderer, modifiers);
		}
		}

		private static native void nDrawTextOnPath(int renderer, char[] text, int index, int count,
		int path, float hOffset, float vOffset, int bidiFlags, int nativePaint);
		int path, float hOffset, float vOffset, int nativePaint);

		@Override
		public void drawTextOnPath(String text, Path path, float hOffset, float vOffset, Paint paint) {
		@@ -1262,28 +1259,25 @@ class GLES20Canvas extends HardwareCanvas {
		int modifiers = setupModifiers(paint);
		try {
		nDrawTextOnPath(mRenderer, text, 0, text.length(), path.mNativePath, hOffset, vOffset,
		paint.mBidiFlags, paint.mNativePaint);
		paint.mNativePaint);
		} finally {
		if (modifiers != MODIFIER_NONE) nResetModifiers(mRenderer, modifiers);
		}
		}

		private static native void nDrawTextOnPath(int renderer, String text, int start, int end,
		int path, float hOffset, float vOffset, int bidiFlags, int nativePaint);
		int path, float hOffset, float vOffset, int nativePaint);

		@Override
		public void drawTextRun(char[] text, int index, int count, int contextIndex, int contextCount,
		float x, float y, int dir, Paint paint) {
		float x, float y, Paint paint) {
		if ((index \| count \| text.length - index - count) < 0) {
		throw new IndexOutOfBoundsException();
		}
		if (dir != DIRECTION_LTR && dir != DIRECTION_RTL) {
		throw new IllegalArgumentException("Unknown direction: " + dir);
		}

		int modifiers = setupModifiers(paint);
		try {
		nDrawTextRun(mRenderer, text, index, count, contextIndex, contextCount, x, y, dir,
		nDrawTextRun(mRenderer, text, index, count, contextIndex, contextCount, x, y,
		paint.mNativePaint);
		} finally {
		if (modifiers != MODIFIER_NONE) nResetModifiers(mRenderer, modifiers);
		@@ -1291,32 +1285,31 @@ class GLES20Canvas extends HardwareCanvas {
		}

		private static native void nDrawTextRun(int renderer, char[] text, int index, int count,
		int contextIndex, int contextCount, float x, float y, int dir, int nativePaint);
		int contextIndex, int contextCount, float x, float y, int nativePaint);

		@Override
		public void drawTextRun(CharSequence text, int start, int end, int contextStart, int contextEnd,
		float x, float y, int dir, Paint paint) {
		float x, float y, Paint paint) {
		if ((start \| end \| end - start \| text.length() - end) < 0) {
		throw new IndexOutOfBoundsException();
		}

		int modifiers = setupModifiers(paint);
		try {
		int flags = dir == 0 ? 0 : 1;
		if (text instanceof String \|\| text instanceof SpannedString \|\|
		text instanceof SpannableString) {
		nDrawTextRun(mRenderer, text.toString(), start, end, contextStart,
		contextEnd, x, y, flags, paint.mNativePaint);
		contextEnd, x, y, paint.mNativePaint);
		} else if (text instanceof GraphicsOperations) {
		((GraphicsOperations) text).drawTextRun(this, start, end,
		contextStart, contextEnd, x, y, flags, paint);
		contextStart, contextEnd, x, y, paint);
		} else {
		int contextLen = contextEnd - contextStart;
		int len = end - start;
		char[] buf = TemporaryBuffer.obtain(contextLen);
		TextUtils.getChars(text, contextStart, contextEnd, buf, 0);
		nDrawTextRun(mRenderer, buf, start - contextStart, len, 0, contextLen,
		x, y, flags, paint.mNativePaint);
		x, y, paint.mNativePaint);
		TemporaryBuffer.recycle(buf);
		}
		} finally {
		@@ -1325,7 +1318,7 @@ class GLES20Canvas extends HardwareCanvas {
		}

		private static native void nDrawTextRun(int renderer, String text, int start, int end,
		int contextStart, int contextEnd, float x, float y, int flags, int nativePaint);
		int contextStart, int contextEnd, float x, float y, int nativePaint);

		@Override
		public void drawVertices(VertexMode mode, int vertexCount, float[] verts, int vertOffset,