Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d5898f9 authored by Roy Chou's avatar Roy Chou
Browse files

fix(magnification panel): magnifier size title may be cut off when large font size 

Like b/280162065 panel diagonal title issue, the size title may be
truncated when different localization or font size. Therefore, we change
the title textview to be a single line marquee so we can avoid the cut off.

Bug: 328519260
Flag: NA
Test: manually
Change-Id: I723d4d2ea016758919c9ad193c10905cb933c014
parent bba8b2fb

packages/SystemUI/res/layout/window_magnification_settings_view.xml

+4 −0
Original line number Diff line number Diff line
@@ -29,9 +29,13 @@ 
        android:layout_height="wrap_content"

        android:orientation="horizontal">

        <TextView

            android:id="@+id/magnifier_size_title"

            android:layout_width="0dp"

            android:layout_height="wrap_content"

            android:layout_weight="1"

            android:singleLine="true"

            android:scrollHorizontally="true"

            android:ellipsize="marquee"

            android:text="@string/accessibility_magnifier_size"

            android:textAppearance="@style/TextAppearance.MagnificationSetting.Title"

            android:focusable="true"

packages/SystemUI/src/com/android/systemui/accessibility/WindowMagnificationSettings.java

+3 −0
Original line number Diff line number Diff line
@@ -98,6 +98,7 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 
    private ImageButton mMediumButton;

    private ImageButton mLargeButton;

    private Button mDoneButton;

    private TextView mSizeTitle;

    private Button mEditButton;

    private ImageButton mFullScreenButton;

    private int mLastSelectedButtonIndex = MagnificationSize.NONE;
@@ -521,6 +522,7 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 
        mMediumButton = mSettingView.findViewById(R.id.magnifier_medium_button);

        mLargeButton = mSettingView.findViewById(R.id.magnifier_large_button);

        mDoneButton = mSettingView.findViewById(R.id.magnifier_done_button);

        mSizeTitle = mSettingView.findViewById(R.id.magnifier_size_title);

        mEditButton = mSettingView.findViewById(R.id.magnifier_edit_button);

        mFullScreenButton = mSettingView.findViewById(R.id.magnifier_full_button);

        mAllowDiagonalScrollingTitle =
@@ -548,6 +550,7 @@ class WindowMagnificationSettings implements MagnificationGestureDetector.OnGest 
        mDoneButton.setOnClickListener(mButtonClickListener);

        mFullScreenButton.setOnClickListener(mButtonClickListener);

        mEditButton.setOnClickListener(mButtonClickListener);

        mSizeTitle.setSelected(true);

        mAllowDiagonalScrollingTitle.setSelected(true);



        mSettingView.setOnApplyWindowInsetsListener((v, insets) -> {